From kde-panel-devel Mon Dec 29 19:03:17 2014 From: "Kai Uwe Broulik" Date: Mon, 29 Dec 2014 19:03:17 +0000 To: kde-panel-devel Subject: Re: Review Request 121720: Load wallpaper immediately on startup Message-Id: <20141229190317.18352.7800 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141987981604346 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7810060226946008021==" --===============7810060226946008021== Content-Type: multipart/alternative; boundary="===============1436849796964490347==" --===============1436849796964490347== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121720/ ----------------------------------------------------------- (Updated Dec. 29, 2014, 7:03 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description ------- When the shell starts we want the wallpaper to show up immediately to get a seamless transition from ksplash. This patch also hides the background color rectangle while the image is not ready yet to prevent it appearing for a split second. The add wallpaper stuff in Component.onCompleted has been removed since the function got fired twice due to the onModelImageChanged which seems to be executed anyway. Diffs ----- wallpapers/image/imagepackage/contents/ui/main.qml 0cb4812 Diff: https://git.reviewboard.kde.org/r/121720/diff/ Testing ------- Logged in, splash screen disappears and the wallpaper is already there. The image seems to be loading fine too. The slideshow also no longer initially loads the default wallpaper but just black and then fade to the slideshow (but this is a bug in the image.cpp where it falls back to the default wallpaper even initially when it's still crawling for images (depending on the number of files it has to scan the default wallpaper can stay there for a second or two)) Thanks, Kai Uwe Broulik --===============1436849796964490347== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121720/

This change has been marked as submitted.

Review request for Plasma.

By Kai Uwe Broulik.

Updated Dec. 29, 2014, 7:03 p.m.

Repository: plasma-workspace

Description

When the shell starts we want the wallpaper to show up immediately to get a seamless transition from ksplash.
This patch also hides the background color rectangle while the image is not ready yet to prevent it appearing for a split second.
The add wallpaper stuff in Component.onCompleted has been removed since the function got fired twice due to the onModelImageChanged which seems to be executed anyway.

Testing

Logged in, splash screen disappears and the wallpaper is already there. The image seems to be loading fine too.

The slideshow also no longer initially loads the default wallpaper but just black and then fade to the slideshow (but this is a bug in the image.cpp where it falls back to the default wallpaper even initially when it's still crawling for images (depending on the number of files it has to scan the default wallpaper can stay there for a second or two))

Diffs

wallpapers/image/imagepackage/contents/ui/main.qml (0cb4812)

--===============1436849796964490347==-- --===============7810060226946008021== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7810060226946008021==--