[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-12-29 14:49:30
Message-ID: 20141229144930.18351.896 () probe ! kde ! org
[Download RAW message or body]
--===============5095070403745218269==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 29, 2014, 4:40 a.m., Aleix Pol Gonzalez wrote:
> > Then Qt5Webkit should be marked as optional through the set_package_properties().
> >
> > To be honest, I'm not thrilled about having many ways to configure these things, \
> > because sooner or later somebody will end up compiling Plasma without qtwebkit by \
> > mistake and then he'll miss drkonqi, but well, building qtwebkit sure is a PITA, \
> > so won't oppose.
>
> Marco Martin wrote:
> anyways, this webkit dependency should be removed sooner than later no? so making \
> it optional would be a good first step.
> Marco Martin wrote:
> also, what exactly drkonqui uses qtwebkit for?
>
> Aleix Pol Gonzalez wrote:
> /home/kde-devel/frameworks/plasma-workspace/drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp \
> uses KWebView for showing a report that the bug has been filled.
> How would you remove the dependency? With QtWebEngine? Isn't it the same thing?
>
> David Faure wrote:
> If it's just to open a URL at the end of process, why not just launch a web \
> browser?
I didn't really think it through, maybe it's a good solution. It's derailing from the \
original patch anyway.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121718/#review72659
-----------------------------------------------------------
On Dec. 28, 2014, 6:16 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121718/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2014, 6:16 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Only drkonqi and systemmonitor depend on it.
>
> (systemmonitor uses libksysguard's processui lib, which is not installed
> by libksysguard if webkit is not found)
>
>
> Diffs
> -----
>
> CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974
> drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67
>
> Diff: https://git.reviewboard.kde.org/r/121718/diff/
>
>
> Testing
> -------
>
> Compiling without qt5 webkit.
>
>
> Thanks,
>
> David Faure
>
>
--===============5095070403745218269==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121718/">https://git.reviewboard.kde.org/r/121718/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 29th, 2014, 4:40 a.m. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Then Qt5Webkit should be marked as optional through \
the set_package_properties().</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">To be honest, I'm not \
thrilled about having many ways to configure these things, because sooner or later \
somebody will end up compiling Plasma without qtwebkit by mistake and then he'll miss \
drkonqi, but well, building qtwebkit sure is a PITA, so won't oppose.</p></pre> \
</blockquote>
<p>On December 29th, 2014, 9:26 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">anyways, this webkit dependency should be removed sooner than later no? so \
making it optional would be a good first step.</p></pre> </blockquote>
<p>On December 29th, 2014, 9:26 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also, \
what exactly drkonqui uses qtwebkit for?</p></pre> </blockquote>
<p>On December 29th, 2014, 1:53 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">/home/kde-devel/frameworks/plasma-workspace/drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp \
uses KWebView for showing a report that the bug has been filled.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">How would you remove the dependency? With QtWebEngine? Isn't it the same \
thing?</p></pre> </blockquote>
<p>On December 29th, 2014, 2:44 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
it's just to open a URL at the end of process, why not just launch a web \
browser?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
didn't really think it through, maybe it's a good solution. It's derailing from the \
original patch anyway.</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On December 28th, 2014, 6:16 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2014, 6:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Only drkonqi and systemmonitor depend on it.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(systemmonitor uses libksysguard's processui lib, which is not installed by \
libksysguard if webkit is not found)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiling without qt5 webkit.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(c6d89c14b05f5639937aee5692d305fa2faed974)</span></li>
<li>drkonqi/CMakeLists.txt <span style="color: \
grey">(a362d7ec651c027d91d0912e84817cd3a2f94d67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121718/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5095070403745218269==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic