'Re: Review Request 121720: Load wallpaper immediately on startup'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121720: Load wallpaper immediately on startup
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-12-29 9:49:41
Message-ID: 20141229094941.18351.86573 () probe ! kde ! org
[Download RAW message or body]

--===============4857772092628719564==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121720/#review72690
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On Dec. 28, 2014, 7:49 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121720/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 7:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When the shell starts we want the wallpaper to show up immediately to get a \
> seamless transition from ksplash. This patch also hides the background color \
> rectangle while the image is not ready yet to prevent it appearing for a split \
> second. The add wallpaper stuff in Component.onCompleted has been removed since the \
> function got fired twice due to the onModelImageChanged which seems to be executed \
> anyway. 
> 
> Diffs
> -----
> 
> wallpapers/image/imagepackage/contents/ui/main.qml 0cb4812 
> 
> Diff: https://git.reviewboard.kde.org/r/121720/diff/
> 
> 
> Testing
> -------
> 
> Logged in, splash screen disappears and the wallpaper is already there. The image \
> seems to be loading fine too. 
> The slideshow also no longer initially loads the default wallpaper but just black \
> and then fade to the slideshow (but this is a bug in the image.cpp where it falls \
> back to the default wallpaper even initially when it's still crawling for images \
> (depending on the number of files it has to scan the default wallpaper can stay \
> there for a second or two)) 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============4857772092628719564==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121720/">https://git.reviewboard.kde.org/r/121720/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On December 28th, 2014, 7:49 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dec. 28, 2014, 7:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When the shell starts we want the wallpaper to show up \
immediately to get a seamless transition from ksplash. This patch also hides the \
background color rectangle while the image is not ready yet to prevent it appearing \
for a split second. The add wallpaper stuff in Component.onCompleted has been removed \
since the function got fired twice due to the onModelImageChanged which seems to be \
executed anyway.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Logged in, splash screen disappears and the wallpaper \
is already there. The image seems to be loading fine too.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
slideshow also no longer initially loads the default wallpaper but just black and \
then fade to the slideshow (but this is a bug in the image.cpp where it falls back to \
the default wallpaper even initially when it's still crawling for images (depending \
on the number of files it has to scan the default wallpaper can stay there for a \
second or two))</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>wallpapers/image/imagepackage/contents/ui/main.qml <span style="color: \
grey">(0cb4812)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121720/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4857772092628719564==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 