From kde-panel-devel Mon Dec 29 09:47:22 2014 From: "Marco Martin" Date: Mon, 29 Dec 2014 09:47:22 +0000 To: kde-panel-devel Subject: Re: Review Request 121728: Fix Label not picking up font changes at runtime Message-Id: <20141229094722.18351.74286 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141984647428578 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6310438465384826254==" --===============6310438465384826254== Content-Type: multipart/alternative; boundary="===============6030443355916677406==" --===============6030443355916677406== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/#review72689 ----------------------------------------------------------- ah, those should be on gerrit btw :p - Marco Martin On Dec. 28, 2014, 10:43 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121728/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2014, 10:43 p.m.) > > > Review request for Plasma. > > > Bugs: 334818 > http://bugs.kde.org/show_bug.cgi?id=334818 > > > Repository: plasma-framework > > > Description > ------- > > The event filter was installed but then removed when the color file path was not empty (read: always). Keeping the event filter around ensures font changes are picked up at runtime. > > > Diffs > ----- > > src/plasma/private/theme_p.cpp 1963f74 > > Diff: https://git.reviewboard.kde.org/r/121728/diff/ > > > Testing > ------- > > Changed my fonts to bold or changed the size, everything updated like magic after hitting the Apply button. > > > Thanks, > > Kai Uwe Broulik > > --===============6030443355916677406== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/

ah, those should be on gerrit btw :p

- Marco Martin

On December 28th, 2014, 10:43 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma.

By Kai Uwe Broulik.

Updated Dec. 28, 2014, 10:43 p.m.

Bugs: 334818

Repository: plasma-framework

Description

The event filter was installed but then removed when the color file path was not empty (read: always). Keeping the event filter around ensures font changes are picked up at runtime.

Testing

Changed my fonts to bold or changed the size, everything updated like magic after hitting the Apply button.

Diffs

src/plasma/private/theme_p.cpp (1963f74)

View Diff

--===============6030443355916677406==-- --===============6310438465384826254== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6310438465384826254==--