[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121701: Introduce KQuickControls TextField with context menu
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-12-29 4:37:33
Message-ID: 20141229043733.18352.61199 () probe ! kde ! org
[Download RAW message or body]
--===============5080070404348939752==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121701/#review72657
-----------------------------------------------------------
+1 to me, it's something that clearly belongs on our side.
Also huge +1 for David for thinking about sonnet.
- Aleix Pol Gonzalez
On Dec. 27, 2014, 7:17 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121701/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2014, 7:17 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> This adds a KQuickControls TextField and TextArea with a context menu similar to \
> what the widgets provide, based on Review 121698.
> It uses the new "menu" property and thus requires QtQuick.Controls 1.3, ie. Qt 5.4 \
> and should eventually be used as base for its PlasmaComponents counterparts. A user \
> of this Item could manupulate menu to remove or add additional items.
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrols/CMakeLists.txt eef0420
> src/qmlcontrols/kquickcontrols/TextArea.qml PRE-CREATION
> src/qmlcontrols/kquickcontrols/TextField.qml PRE-CREATION
> src/qmlcontrols/kquickcontrols/private/CMakeLists.txt c024800
> src/qmlcontrols/kquickcontrols/private/TextMenu.qml PRE-CREATION
> src/qmlcontrols/kquickcontrols/private/qmldir 8770bce
> src/qmlcontrols/kquickcontrols/qmldir 31d8b14
>
> Diff: https://git.reviewboard.kde.org/r/121701/diff/
>
>
> Testing
> -------
>
> Works in qmlscene, was too lazy recompiling the frameworksintegration for Qt 5.4
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============5080070404348939752==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121701/">https://git.reviewboard.kde.org/r/121701/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 to \
me, it's something that clearly belongs on our side.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
huge +1 for David for thinking about sonnet.</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On December 27th, 2014, 7:17 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2014, 7:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a KQuickControls TextField and TextArea with \
a context menu similar to what the widgets provide, based on Review 121698.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It uses the new "menu" property and thus requires QtQuick.Controls 1.3, ie. \
Qt 5.4 and should eventually be used as base for its PlasmaComponents counterparts. A \
user of this Item could manupulate menu to remove or add additional items.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works in qmlscene, was too lazy recompiling the \
frameworksintegration for Qt 5.4</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/kquickcontrols/CMakeLists.txt <span style="color: \
grey">(eef0420)</span></li>
<li>src/qmlcontrols/kquickcontrols/TextArea.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/TextField.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/private/CMakeLists.txt <span style="color: \
grey">(c024800)</span></li>
<li>src/qmlcontrols/kquickcontrols/private/TextMenu.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/private/qmldir <span style="color: \
grey">(8770bce)</span></li>
<li>src/qmlcontrols/kquickcontrols/qmldir <span style="color: \
grey">(31d8b14)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121701/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5080070404348939752==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic