[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121722: Bring back computer-laptop icon for kickoff
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-12-28 20:35:32
Message-ID: 20141228203532.18351.34444 () probe ! kde ! org
[Download RAW message or body]
--===============5902081724719269999==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121722/
-----------------------------------------------------------
(Updated Dec. 28, 2014, 8:35 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Sebastian Kügler.
Repository: plasma-desktop
Description
-------
Show computer-laptop icon when we're on a laptop (now checks whether you have a lid \
in your computer rather than if there are any batteries like the 4.x one did, much \
more reliable)
Diffs
-----
applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c
Diff: https://git.reviewboard.kde.org/r/121722/diff/
Testing
-------
Shows a laptop on my laptop. It's the little things ;)
File Attachments
----------------
Laptop in action
https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png
Thanks,
Kai Uwe Broulik
--===============5902081724719269999==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121722/">https://git.reviewboard.kde.org/r/121722/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2014, 8:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Show computer-laptop icon when we're on a laptop (now \
checks whether you have a lid in your computer rather than if there are any batteries \
like the 4.x one did, much more reliable)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Shows a laptop on my laptop. It's the little things \
;)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(0a3d26c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121722/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png">Laptop \
in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5902081724719269999==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic