[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder
From: Lukáš Tinkl <lukas () kde ! org>
Date: 2014-12-28 20:21:44
Message-ID: 20141228202144.18352.88646 () probe ! kde ! org
[Download RAW message or body]
--===============0938567110383664612==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121724/#review72622
-----------------------------------------------------------
Ship it!
Ship It!
- Lukáš Tinkl
On Pro. 28, 2014, 9:17 odp., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121724/
> -----------------------------------------------------------
>
> (Updated Pro. 28, 2014, 9:17 odp.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Before the move to QQC we used a Label with opacity 0.5 to gray it out.
> I suggested using Qt.tint but tinting a black label (in case of a light theme) with \
> semi-transparent black still stays black.
> Instead I read the documentation and found a little paragraph "Oh, by the way, \
> there's r, g, b, a properties on every color".
>
> Diffs
> -----
>
> src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718
>
> Diff: https://git.reviewboard.kde.org/r/121724/diff/
>
>
> Testing
> -------
>
> Works fine on both light and dark breeze again.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============0938567110383664612==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121724/">https://git.reviewboard.kde.org/r/121724/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- Lukáš Tinkl</p>
<br />
<p>On prosinec 28th, 2014, 9:17 odp. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Pro. 28, 2014, 9:17 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Before the move to QQC we used a Label with opacity \
0.5 to gray it out. I suggested using Qt.tint but tinting a black label (in case of a \
light theme) with semi-transparent black still stays black.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Instead I read the documentation and found a little paragraph "Oh, by the \
way, there's r, g, b, a properties on every color".</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works fine on both light and dark breeze \
again.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmastyle/TextFieldStyle.qml <span style="color: \
grey">(2e5b718)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121724/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0938567110383664612==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic