[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121698: Add edit context menu to TextField/TextArea
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-12-27 17:46:08
Message-ID: 20141227174608.13119.86898 () probe ! kde ! org
[Download RAW message or body]
--===============5866685657473968064==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121698/
-----------------------------------------------------------
(Updated Dez. 27, 2014, 5:46 nachm.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: plasma-framework
Description
-------
This adds a context menu that is similar to what is found on regular \
textfields/textareas consisting of
- Undo
- Redo
- Cut
- Copy
- Paste
- Delete
- Clear
- Select All
It does not show the standard shortcuts as I couldn't figure out how that would be \
done. There's a "StandardKey" referenced by the QQC Action item but I couldn't find \
documentation about it and also I cannot use Action {} in a MenuItem.
Diffs
-----
src/declarativeimports/plasmastyle/TextAreaStyle.qml 41299c5
src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718
src/declarativeimports/plasmastyle/private/EditContextMenuArea.qml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121698/diff/
Testing
-------
The menu seems to work as expected, items are enabled/disabled as needed or when the \
control is disabled. The MouseArea doesn't errorneously eat events either.
File Attachments
----------------
Context menu in action
https://git.reviewboard.kde.org/media/uploaded/files/2014/12/27/ab2162e2-dc13-4c99-9a66-aaeeb08b6384__editcontextmenu.png
Thanks,
Kai Uwe Broulik
--===============5866685657473968064==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121698/">https://git.reviewboard.kde.org/r/121698/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dez. 27, 2014, 5:46 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a context menu that is similar to what is \
found on regular textfields/textareas consisting of
- Undo
- Redo
- Cut
- Copy
- Paste
- Delete
- Clear
- Select All</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It does not show the standard shortcuts as I couldn't \
figure out how that would be done. There's a "StandardKey" referenced by the QQC \
Action item but I couldn't find documentation about it and also I cannot use Action \
{} in a MenuItem.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The menu seems to work as expected, items are \
enabled/disabled as needed or when the control is disabled. The MouseArea doesn't \
errorneously eat events either.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmastyle/TextAreaStyle.qml <span style="color: \
grey">(41299c5)</span></li>
<li>src/declarativeimports/plasmastyle/TextFieldStyle.qml <span style="color: \
grey">(2e5b718)</span></li>
<li>src/declarativeimports/plasmastyle/private/EditContextMenuArea.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121698/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/27/ab2162e2-dc13-4c99-9a66-aaeeb08b6384__editcontextmenu.png">Context \
menu in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5866685657473968064==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic