[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120965: Base panelcontroller and more settings menu on button sizes
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-12-18 12:50:06
Message-ID: 20141218125006.31946.81189 () probe ! kde ! org
[Download RAW message or body]
--===============1485796771764334296==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120965/
-----------------------------------------------------------
(Updated Dez. 18, 2014, 12:50 nachm.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: plasma-desktop
Description
-------
Not every language has short fancy expressions for things and thus stuff breaks when \
using it in German, for example the "Windows can cover" or "Add spacer" button were \
cut off. This fixes this by accounting the button widths in the minimum width.
Diffs
-----
desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml \
2ab662c desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml \
7cf567e
Diff: https://git.reviewboard.kde.org/r/120965/diff/
Testing
-------
No more cut off buttons, but it seems there's an issue with re-layouting when \
dragging a horizontal to a side.
Thanks,
Kai Uwe Broulik
--===============1485796771764334296==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120965/">https://git.reviewboard.kde.org/r/120965/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dez. 18, 2014, 12:50 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Not every language has short fancy expressions for \
things and thus stuff breaks when using it in German, for example the "Windows can \
cover" or "Add spacer" button were cut off. This fixes this by accounting the button \
widths in the minimum width.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">No more cut off buttons, but it seems there's an issue \
with re-layouting when dragging a horizontal to a side.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml \
<span style="color: grey">(2ab662c)</span></li>
<li>desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml <span \
style="color: grey">(7cf567e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120965/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1485796771764334296==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic