[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121581: Plotter in kdeclarative
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-12-18 1:05:27
Message-ID: 20141218010527.31946.98936 () probe ! kde ! org
[Download RAW message or body]
--===============3158568972148189765==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121581/#review72219
-----------------------------------------------------------
I think it's a useful component that can end up being really useful elsewhere, \
therefore I think kdeclarative it's a good place to be.
I'd say it would be better to have it in a separate qml module. IIRC, the idea of \
kquickcontrols was to provide components that extend QtQuick Controls, rather than \
such generic components (see the KeySequenceButton). In fact, I would expect that to \
use something like that, I'd have to "import org.kde.plotter" or "import \
QtQuick.Plotter" rather than something else that happens to provide a Plotter class.
Also I miss some more development over it, to get started some unit tests would be \
perfect, or at least an example application we can look at to test small things or \
just learn how to use it.
Last, have you looked at the plotting component developed for ktouch? Is it \
comparable in any way? I'd love to duplicate there. \
https://projects.kde.org/projects/kde/kdeedu/kqtquickcharts/repository
Thanks!
- Aleix Pol Gonzalez
On Dec. 17, 2014, 4:20 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121581/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2014, 4:20 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> This is an alternative, mutually exclusive to
> https://gerrit.vesnicky.cesnet.cz/r/#/c/244
> and dependent from
> https://git.reviewboard.kde.org/r/121575/
>
> since the plotter component doesn't depend from libplasma, it may be useful to have \
> it outside of libplasma, so any applciation that wants it may use it. Any opinion \
> whether this should go here or in libplasma is welcome.
>
> Diffs
> -----
>
> CMakeLists.txt 233ccce
> src/qmlcontrols/kquickcontrols/CMakeLists.txt eef0420
> src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.h PRE-CREATION
> src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.cpp PRE-CREATION
> src/qmlcontrols/kquickcontrols/plotter.h PRE-CREATION
> src/qmlcontrols/kquickcontrols/plotter.cpp PRE-CREATION
> src/qmlcontrols/kquickcontrols/qmldir 31d8b14
>
> Diff: https://git.reviewboard.kde.org/r/121581/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============3158568972148189765==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121581/">https://git.reviewboard.kde.org/r/121581/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it's a useful component that can end up being really useful elsewhere, \
therefore I think kdeclarative it's a good place to be.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
say it would be better to have it in a separate qml module. IIRC, the idea of \
kquickcontrols was to provide components that extend QtQuick Controls, rather than \
such generic components (see the KeySequenceButton). In fact, I would expect that to \
use something like that, I'd have to "import org.kde.plotter" or "import \
QtQuick.Plotter" rather than something else that happens to provide a Plotter \
class.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also I miss some more development over it, to get \
started some unit tests would be perfect, or at least an example application we can \
look at to test small things or just learn how to use it.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Last, \
have you looked at the plotting component developed for ktouch? Is it comparable in \
any way? I'd love to duplicate there. \
https://projects.kde.org/projects/kde/kdeedu/kqtquickcharts/repository</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks!</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On December 17th, 2014, 4:20 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2014, 4:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is an alternative, mutually exclusive to \
https://gerrit.vesnicky.cesnet.cz/r/#/c/244 and dependent from
https://git.reviewboard.kde.org/r/121575/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">since the plotter component doesn't depend from \
libplasma, it may be useful to have it outside of libplasma, so any applciation that \
wants it may use it. Any opinion whether this should go here or in libplasma is \
welcome.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(233ccce)</span></li>
<li>src/qmlcontrols/kquickcontrols/CMakeLists.txt <span style="color: \
grey">(eef0420)</span></li>
<li>src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/plotter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/plotter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrols/qmldir <span style="color: \
grey">(31d8b14)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121581/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3158568972148189765==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic