[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121563: Fix build with Qt 5.5/dev branch in release mode
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-12-17 6:57:57
Message-ID: 20141217065757.31946.27420 () probe ! kde ! org
[Download RAW message or body]
--===============2424944074292502843==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121563/#review72162
-----------------------------------------------------------
but that will now create a unused variable warning in release mode...
- Martin Gräßlin
On Dec. 16, 2014, 7:19 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121563/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 7:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: libksysguard
>
>
> Description
> -------
>
> same as review 121562:
> "since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty \
> Q_ASSERT still check its argument for validity" the build shall fail. alternative \
> is to guard the Q_ASSERT with QT_NO_DEBUG"
>
> Diffs
> -----
>
> processcore/processes.cpp 6c0effc
>
> Diff: https://git.reviewboard.kde.org/r/121563/diff/
>
>
> Testing
> -------
>
> builds with both 5.4 & dev branch
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============2424944074292502843==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121563/">https://git.reviewboard.kde.org/r/121563/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but \
that will now create a unused variable warning in release mode...</p></pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On December 16th, 2014, 7:19 p.m. CET, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2014, 7:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">same as review 121562: "since qtbase commit \
ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty Q_ASSERT still check its \
argument for validity" the build shall fail. alternative is to guard the Q_ASSERT \
with QT_NO_DEBUG"</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds with both 5.4 & dev branch</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>processcore/processes.cpp <span style="color: grey">(6c0effc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121563/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2424944074292502843==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic