'Re: Review Request 121311: Remove mnemonic underlines when alt-tabbing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121311: Remove mnemonic underlines when alt-tabbing
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-12-01 14:48:25
Message-ID: 20141201144825.22787.67513 () probe ! kde ! org
[Download RAW message or body]

--===============0045076680153501525==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121311/#review71189
-----------------------------------------------------------

this is not a sufficient solution (I fear). Scnario:
1. go to application and press Alt
2. move mouse to trigger Present Windows effect
3. release alt key
4. activate same application again

=> will still be underlined as the application state never changed, but the \
application never got the key release event.

The root problem here is not that the active application changes, but that another \
process grabs the X11 keyboard. What would be needed is to detect that the keyboard \
is grabbed. Otherwise it will fail with any such setups where a keyboard grab is \
involved.

- Martin Gräßlin

On Dec. 1, 2014, 3:42 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121311/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 3:42 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> Remove mnemonic underlines when alt-tabbing
> 
> Alt+tab messes with the nmemonics.
> In Qt5 we get a keyPressEvent, then we lose focus and don't receive a
> keyReleaseEvent
> 
> This means the application keeps showing the mnemonic helpers even when
> we switch back to the application.
> 
> BUG: 341006
> 
> 
> Diffs
> -----
> 
> kstyle/breezemnemonics.cpp 9395ea9 
> 
> Diff: https://git.reviewboard.kde.org/r/121311/diff/
> 
> 
> Testing
> -------
> 
> Ran dolphin, pressed alt+tab a lot. Even with multiple windows it seems OK.
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============0045076680153501525==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121311/">https://git.reviewboard.kde.org/r/121311/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
is not a sufficient solution (I fear). Scnario: 1. go to application and press Alt
2. move mouse to trigger Present Windows effect
3. release alt key
4. activate same application again</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">=&gt; will still be underlined as the application \
state never changed, but the application never got the key release event.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The root problem here is not that the active application changes, but that \
another process grabs the X11 keyboard. What would be needed is to detect that the \
keyboard is grabbed. Otherwise it will fail with any such setups where a keyboard \
grab is involved.</p></pre>  <br />

<p>- Martin Gräßlin</p>

<br />
<p>On December 1st, 2014, 3:42 p.m. CET, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Dec. 1, 2014, 3:42 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove mnemonic underlines when alt-tabbing</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Alt+tab messes with the nmemonics. In Qt5 we get a keyPressEvent, then we \
lose focus and don't receive a keyReleaseEvent</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This means the application keeps showing the mnemonic \
helpers even when we switch back to the application.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 341006</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran dolphin, pressed alt+tab a lot. Even with multiple \
windows it seems OK.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyle/breezemnemonics.cpp <span style="color: grey">(9395ea9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121311/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0045076680153501525==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 