[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 121294: Improve wallpaper sourceSize handling
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-11-30 14:48:14
Message-ID: 20141130144814.22787.23707 () probe ! kde ! org
[Download RAW message or body]
--===============1143008885399233506==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121294/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Do not bind the image's sourceSize to the root item's size since that will reload the \
image whenever the size changes. This is especially noticeable in plasmoidviewer \
where resizing the window causes the background to go black momentarily.
This makes it wait 1s before actually changing the source size, preventing continuous \
reloading when resizing the window but should also improve resolution changes. Also, \
it waits for the size to become non-zero before loading the image. Setting a \
sourceSize of (0,0) is equivalent to not setting it at all, causing it to load the \
full image, just to reload it in the proper size afterwards.
There's still an issue that the view starts up with a size of 1024x768, loads the \
wallpaper, and then resizes itself to the screen geometry, causing a delayed reload \
of the image which was previously not visible but together with me waiting for the \
size to become available you can see that on plasmashell startup, when using eg. the \
tiled fill mode.
Unrelated:
- Move the swap image stuff into a separate function
- Use my animate binding trick for fillMode change too, now these are lag-free also
Diffs
-----
wallpapers/image/imagepackage/contents/ui/main.qml 17683c0
Diff: https://git.reviewboard.kde.org/r/121294/diff/
Testing
-------
Plasmoidviewer is much prettier to use now, no flickering, Plasmashell startup is a \
bit more nasty imho (especially when using a wallpaper background color) but should \
be concealed by ksplash. Switching between wallpapers and fillmodes is smooth, it \
fades from black when changing a wallpaper and fillmode at the same time but afaics \
that has been the case previously, too.
Thanks,
Kai Uwe Broulik
--===============1143008885399233506==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121294/">https://git.reviewboard.kde.org/r/121294/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Do not bind the image's sourceSize to the root item's \
size since that will reload the image whenever the size changes. This is especially \
noticeable in plasmoidviewer where resizing the window causes the background to go \
black momentarily.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This makes it wait 1s before actually \
changing the source size, preventing continuous reloading when resizing the window \
but should also improve resolution changes. Also, it waits for the size to become \
non-zero before loading the image. Setting a sourceSize of (0,0) is equivalent to not \
setting it at all, causing it to load the full image, just to reload it in the proper \
size afterwards.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">There's still an issue that the view \
starts up with a size of 1024x768, loads the wallpaper, and then resizes itself to \
the screen geometry, causing a delayed reload of the image which was previously not \
visible but together with me waiting for the size to become available you can see \
that on plasmashell startup, when using eg. the tiled fill mode.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Unrelated:
- Move the swap image stuff into a separate function
- Use my animate binding trick for fillMode change too, now these are lag-free \
also</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Plasmoidviewer is much prettier to use now, no \
flickering, Plasmashell startup is a bit more nasty imho (especially when using a \
wallpaper background color) but should be concealed by ksplash. Switching between \
wallpapers and fillmodes is smooth, it fades from black when changing a wallpaper and \
fillmode at the same time but afaics that has been the case previously, \
too.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>wallpapers/image/imagepackage/contents/ui/main.qml <span style="color: \
grey">(17683c0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121294/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1143008885399233506==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic