'Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-11-26 18:39:33
Message-ID: 20141126183933.11306.89729 () probe ! kde ! org
[Download RAW message or body]

--===============3002704921063612606==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120777/#review70975
-----------------------------------------------------------

Ship it!

looks better to me

- Marco Martin

On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120777/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 6:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> At the moment, Baloo doesn't provide a timeline, which is something that we need \
> for the activefilebrowser. So this new component, is introducing support for the \
> timeline. 
> Notes
> ===
> 
> * Baloocloud component contains the org.kde.baloo component inside it.The reason \
> behind that, is that the implementation for the timeline is kind of terible because \
>                 of its perfomance.
> * I have put the new component inside the plasma-mobile repository, for the above \
> reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I \
>                 am fine with both approaches (keep it here or in the baloo \
>                 repository.
> * If someone has a better idea about the implementation, the pls shoot :)
> 
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt 9466447 
> components/CMakeLists.txt 536b60e 
> components/timelinemodel/CMakeLists.txt PRE-CREATION 
> components/timelinemodel/qmldir PRE-CREATION 
> components/timelinemodel/timelinemodel.h PRE-CREATION 
> components/timelinemodel/timelinemodel.cpp PRE-CREATION 
> components/timelinemodel/timelineplugin.h PRE-CREATION 
> components/timelinemodel/timelineplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120777/diff/
> 
> 
> Testing
> -------
> 
> Everything looks ok. The performance is not bad, except from the fact that the \
> implementation is a bit of hackish... 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
> 

--===============3002704921063612606==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120777/">https://git.reviewboard.kde.org/r/120777/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">looks \
better to me</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On November 26th, 2014, 6:11 p.m. UTC, Antonis Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2014, 6:11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">At the moment, Baloo doesn't provide a timeline, which \
is something that we need for the activefilebrowser. So this new component, is \
introducing support for the timeline.</p> <h1 style="font-size: 100%;text-rendering: \
inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Notes</h1> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Baloocloud component contains the \
org.kde.baloo component inside it.The reason behind that, is that the implementation \
for the timeline is kind of terible because of its perfomance.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">I have put the new component inside the plasma-mobile repository, for the \
above reason. But if the Baloo team, wants it inside the baloo repo then i can move \
it. I am fine with both approaches (keep it here or in the baloo repository.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">If someone has a better idea about the implementation, the pls shoot :)</li> \
</ul></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything looks ok. The performance is not bad, \
except from the fact that the implementation is a bit of hackish...</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(9466447)</span></li>

 <li>components/CMakeLists.txt <span style="color: grey">(536b60e)</span></li>

 <li>components/timelinemodel/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/timelinemodel/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/timelinemodel/timelinemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/timelinemodel/timelinemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/timelinemodel/timelineplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>components/timelinemodel/timelineplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120777/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3002704921063612606==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 