'Re: Review Request 121253: Fix password focus in lockscreen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121253: Fix password focus in lockscreen
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2014-11-26 12:45:42
Message-ID: 20141126124542.11306.90271 () probe ! kde ! org
[Download RAW message or body]

--===============5222533504700558321==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121253/
-----------------------------------------------------------

(Updated Nov. 26, 2014, 12:45 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-workspace

Description
-------

Fix password focus in lockscreen

When navigating the listview with the keyboard, the focus of the
password field can get lost as it moves to the button. This patch
reclaims the focus whenever the password field becomes visible.

Diffs
-----

  lookandfeel/contents/lockscreen/LockScreen.qml \
8a495ea208325ba3b2ef09efaef49515cc99830d 

Diff: https://git.reviewboard.kde.org/r/121253/diff/

Testing
-------

Navigated lockscreen with keyboard and mouse. Focus is handled correctly.

Thanks,

Sebastian Kügler

--===============5222533504700558321==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121253/">https://git.reviewboard.kde.org/r/121253/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2014, 12:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix password focus in lockscreen</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">When navigating the listview with the keyboard, the focus of the password \
field can get lost as it moves to the button. This patch reclaims the focus whenever \
the password field becomes visible.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Navigated lockscreen with keyboard and mouse. Focus is \
handled correctly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: \
grey">(8a495ea208325ba3b2ef09efaef49515cc99830d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121253/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5222533504700558321==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 