'Re: Review Request 121244: Remove workarounds we had for the nested event loops'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121244: Remove workarounds we had for the nested event loops
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2014-11-25 23:58:12
Message-ID: 20141125235812.11305.24031 () probe ! kde ! org
[Download RAW message or body]

--===============6876471237699831374==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121244/
-----------------------------------------------------------

(Updated Nov. 25, 2014, 11:58 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-workspace

Description
-------

Instead of keeping the state, expect the code to follow the order it's expected from it.

Needs to bump the KF5 requirement to current KDeclarative (master), or it can run in problems.

Diffs
-----

  CMakeLists.txt 7856833 
  shell/shellcorona.h 37f8b0e 
  shell/shellcorona.cpp fd8e9b7 

Diff: https://git.reviewboard.kde.org/r/121244/diff/

Testing
-------

Been running it for the last week.

Thanks,

Aleix Pol Gonzalez

--===============6876471237699831374==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121244/">https://git.reviewboard.kde.org/r/121244/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Nov. 25, 2014, 11:58 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Instead of \
keeping the state, expect the code to follow the order it's expected from it.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Needs to bump the KF5 requirement to current KDeclarative (master), or it can run in \
problems.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Been running it \
for the last week.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(7856833)</span></li>

 <li>shell/shellcorona.h <span style="color: grey">(37f8b0e)</span></li>

 <li>shell/shellcorona.cpp <span style="color: grey">(fd8e9b7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121244/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6876471237699831374==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 