[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121244: Remove workarounds we had for the nested event loops
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-11-25 23:56:29
Message-ID: 20141125235629.11305.2165 () probe ! kde ! org
[Download RAW message or body]
--===============0603055584781593112==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 25, 2014, 6:43 p.m., Marco Martin wrote:
> > CMakeLists.txt, line 16
> > <https://git.reviewboard.kde.org/r/121244/diff/1/?file=330671#file330671line16>
> >
> > unrelated commit?
No, I just can't enforce 5.4 if Baloo is 5.2, so I moved it into a separate \
find_package call.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121244/#review70944
-----------------------------------------------------------
On Nov. 25, 2014, 6:33 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121244/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:33 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Instead of keeping the state, expect the code to follow the order it's expected \
> from it.
> Needs to bump the KF5 requirement to current KDeclarative (master), or it can run \
> in problems.
>
> Diffs
> -----
>
> CMakeLists.txt 7856833
> shell/shellcorona.h 37f8b0e
> shell/shellcorona.cpp fd8e9b7
>
> Diff: https://git.reviewboard.kde.org/r/121244/diff/
>
>
> Testing
> -------
>
> Been running it for the last week.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============0603055584781593112==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121244/">https://git.reviewboard.kde.org/r/121244/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 25th, 2014, 6:43 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121244/diff/1/?file=330671#file330671line16" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">16</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">Plasma</span> <span class="s">DocTools</span> <span class="s">Runner</span> \
<span class="s">JsEmbed</span> <span class="s">NotifyConfig</span> <span \
class="s">Su</span> <span class="s">NewStuff</span> <span class="s">Wallet</span> \
<span class="s">KCMUtils</span><span class="hl"> </span><span class="s"><span \
class="hl">Baloo</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">16</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="s">Plasma</span> <span class="s">DocTools</span> <span class="s">Runner</span> \
<span class="s">JsEmbed</span> <span class="s">NotifyConfig</span> <span \
class="s">Su</span> <span class="s">NewStuff</span> <span class="s">Wallet</span> \
<span class="s">KCMUtils</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">unrelated commit?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">No, I just can't enforce 5.4 if Baloo is 5.2, so I moved it into a separate \
find_package call.</p></pre> <br />
<p>- Aleix</p>
<br />
<p>On November 25th, 2014, 6:33 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2014, 6:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Instead of keeping the state, expect the code to \
follow the order it's expected from it.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Needs to bump the KF5 \
requirement to current KDeclarative (master), or it can run in problems.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Been running it for the last week.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7856833)</span></li>
<li>shell/shellcorona.h <span style="color: grey">(37f8b0e)</span></li>
<li>shell/shellcorona.cpp <span style="color: grey">(fd8e9b7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121244/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0603055584781593112==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic