[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-11-25 15:48:28
Message-ID: 20141125154828.11305.2454 () probe ! kde ! org
[Download RAW message or body]
--===============2363724804509251309==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 25, 2014, 3:39 p.m., Vishesh Handa wrote:
> > components/timelinemodel/timelinemodel.cpp, line 144
> > <https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line144>
> >
> > Just my opinion -
> >
> > An assert would be better since m_level is an enum and should NEVER be any other \
> > value apart from those 3.
+1
> On Nov. 25, 2014, 3:39 p.m., Vishesh Handa wrote:
> > components/timelinemodel/timelinemodel.cpp, line 103
> > <https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line103>
> >
> > I'm a little confused. Where is this value being used?
yeah, this doesn't look right.
the query should be constructed in a way that only results within dates between \
startDate and endDate are considered. right now those values don't seem used at all?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120777/#review70926
-----------------------------------------------------------
On Nov. 25, 2014, 3:11 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120777/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 3:11 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mobile
>
>
> Description
> -------
>
> At the moment, Baloo doesn't provide a timeline, which is something that we need \
> for the activefilebrowser. So this new component, is introducing support for the \
> timeline.
> Notes
> ===
>
> * Baloocloud component contains the org.kde.baloo component inside it.The reason \
> behind that, is that the implementation for the timeline is kind of terible because \
> of its perfomance.
> * I have put the new component inside the plasma-mobile repository, for the above \
> reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I \
> am fine with both approaches (keep it here or in the baloo \
> repository.
> * If someone has a better idea about the implementation, the pls shoot :)
>
>
>
> Diffs
> -----
>
> components/CMakeLists.txt 536b60e
> components/timelinemodel/CMakeLists.txt PRE-CREATION
> components/timelinemodel/qmldir PRE-CREATION
> components/timelinemodel/timelinemodel.h PRE-CREATION
> components/timelinemodel/timelinemodel.cpp PRE-CREATION
> components/timelinemodel/timelineplugin.h PRE-CREATION
> components/timelinemodel/timelineplugin.cpp PRE-CREATION
> CMakeLists.txt 9466447
>
> Diff: https://git.reviewboard.kde.org/r/120777/diff/
>
>
> Testing
> -------
>
> Everything looks ok. The performance is not bad, except from the fact that the \
> implementation is a bit of hackish...
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
--===============2363724804509251309==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120777/">https://git.reviewboard.kde.org/r/120777/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 25th, 2014, 3:39 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/timelinemodel/timelinemodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_startDate</span> <span class="o">=</span> <span \
class="n">startDate</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a \
little confused. Where is this value being used?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">yeah, this doesn't look right.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">the query should be \
constructed in a way that only results within dates between startDate and endDate are \
considered. right now those values don't seem used at all?</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 25th, 2014, 3:39 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line144" \
style="color: black; font-weight: bold; text-decoration: \
underline;">components/timelinemodel/timelinemodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">144</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">m_level</span> <span \
class="o">!=</span> <span class="n">TimeLineModel</span><span \
class="o">::</span><span class="n">Year</span> <span class="o">&&</span> \
<span class="n">m_level</span> <span class="o">!=</span> <span \
class="n">TimeLineModel</span><span class="o">::</span><span class="n">Month</span> \
<span class="o">&&</span> <span class="n">m_level</span> <span \
class="o">!=</span> <span class="n">TimeLineModel</span><span \
class="o">::</span><span class="n">Day</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just \
my opinion -</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">An assert would be better since m_level is an enum and \
should NEVER be any other value apart from those 3.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p></pre> <br />
<p>- Marco</p>
<br />
<p>On November 25th, 2014, 3:11 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2014, 3:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">At the moment, Baloo doesn't provide a timeline, which \
is something that we need for the activefilebrowser. So this new component, is \
introducing support for the timeline.</p> <h1 style="font-size: 100%;text-rendering: \
inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Notes</h1> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Baloocloud component contains the \
org.kde.baloo component inside it.The reason behind that, is that the implementation \
for the timeline is kind of terible because of its perfomance.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">I have put the new component inside the plasma-mobile repository, for the \
above reason. But if the Baloo team, wants it inside the baloo repo then i can move \
it. I am fine with both approaches (keep it here or in the baloo repository.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">If someone has a better idea about the implementation, the pls shoot :)</li> \
</ul></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything looks ok. The performance is not bad, \
except from the fact that the implementation is a bit of hackish...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>components/CMakeLists.txt <span style="color: grey">(536b60e)</span></li>
<li>components/timelinemodel/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelinemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelinemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelineplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelineplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(9466447)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120777/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2363724804509251309==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic