'Re: Review Request 121229: Highlight first entry when searching'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121229: Highlight first entry when searching
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2014-11-24 17:36:24
Message-ID: 20141124173624.11306.49142 () probe ! kde ! org
[Download RAW message or body]

--===============3115599775648401485==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121229/#review70859
-----------------------------------------------------------

Definitely, does pressing up & down work as expected too?

In fact, here it looks like I already get a highlight delegate...

- Aleix Pol Gonzalez

On Nov. 24, 2014, 5:27 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121229/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 5:27 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Bugs: 340067
> https://bugs.kde.org/show_bug.cgi?id=340067
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Since pressing enter invokes the first entry it should be highlighted.
> 
> 
> Diffs
> -----
> 
> applets/kickoff/package/contents/ui/SearchView.qml 9fc8d40 
> 
> Diff: https://git.reviewboard.kde.org/r/121229/diff/
> 
> 
> Testing
> -------
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============3115599775648401485==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121229/">https://git.reviewboard.kde.org/r/121229/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Definitely, does pressing up &amp; down work as expected too?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">In fact, here it looks like I already get a highlight delegate...</p></pre> \
<br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On November 24th, 2014, 5:27 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Nov. 24, 2014, 5:27 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=340067">340067</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since pressing enter invokes the first entry it should \
be highlighted.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works as expected.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kickoff/package/contents/ui/SearchView.qml <span style="color: \
grey">(9fc8d40)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121229/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3115599775648401485==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 