'Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-11-19 10:39:49
Message-ID: 20141119103949.22979.2080 () probe ! kde ! org
[Download RAW message or body]

--===============4474132808547212459==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121113/
-----------------------------------------------------------

(Updated Nov. 19, 2014, 10:39 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Repository: kdeclarative

Description
-------

We had a while loop which processed all application events whilst we
were in the middle of creating objects. This leads to weird bugs, and
workarounds in ShellCorona.

Qt's methods forceCompletion does not seem to have the same problems and
works just as well.

Diffs
-----

  src/kdeclarative/qmlobject.cpp 029edaf 

Diff: https://git.reviewboard.kde.org/r/121113/diff/

Testing
-------

Ran plasmashell with many panels filled with applets

Added debug on void ShellCorona::createWaitingPanels() to make sure it was never \
called with m_loading true.

Thanks,

David Edmundson

--===============4474132808547212459==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121113/">https://git.reviewboard.kde.org/r/121113/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Nov. 19, 2014, 10:39 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We had a while loop which processed all application \
events whilst we were in the middle of creating objects. This leads to weird bugs, \
and workarounds in ShellCorona.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Qt's methods forceCompletion does not seem to have the \
same problems and works just as well.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran plasmashell with many panels filled with \
applets</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added debug on void ShellCorona::createWaitingPanels() \
to make sure it was never called with m_loading true.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kdeclarative/qmlobject.cpp <span style="color: grey">(029edaf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121113/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4474132808547212459==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 