[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2014-11-02 15:17:57
Message-ID: 20141102151757.9635.78978 () probe ! kde ! org
[Download RAW message or body]
--===============7300591872367247972==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 2, 2014, 7:01 p.m., Bhushan Shah wrote:
> > browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9
> > <https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9>
> >
> > Don't use find_libarary as well as never hardcode locations. Instead use \
> > find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example
>
> Ashish Bansal wrote:
> Like this -> find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's \
> okay because cmake is unable to find its path for me that's why I hardcoded its \
> path.
> Bhushan Shah wrote:
> umm nope but like this,
>
> find_package(LibKGAPI2 REQUIRED)
>
> Ashish Bansal wrote:
> Now, I am getting undefined references to all the functions and variables related \
> to that Library. In ccmake,
> LibKGAPI2_DIR /usr/lib64/cmake/LibKGAPI2
See
http://lxr.kde.org/source/kde/kdepim-runtime/CMakeLists.txt
http://lxr.kde.org/source/kde/kdepim-runtime/resources/gmail/CMakeLists.txt
To see how it is done..
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120855/#review69671
-----------------------------------------------------------
On Nov. 2, 2014, 8:47 p.m., Ashish Bansal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120855/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 8:47 p.m.)
>
>
> Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, \
> Sinny Kumari, and Sujith Haridasan.
>
> Bugs: 336398
> http://bugs.kde.org/show_bug.cgi?id=336398
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Changed auth method from Client Login to OAuth using libkgapi2
>
>
> Diffs
> -----
>
> browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d
> browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7
> browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240
> browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 \
> browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310
> browsingbackends/onlineservices/picasa/picasamodel.h 5bce055
> browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156
>
> Diff: https://git.reviewboard.kde.org/r/120855/diff/
>
>
> Testing
> -------
>
> Everything is working fine except that after successful login, user has to press \
> back to view all the albums.
>
> Thanks,
>
> Ashish Bansal
>
>
--===============7300591872367247972==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120855/">https://git.reviewboard.kde.org/r/120855/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 2nd, 2014, 7:01 p.m. IST, <b>Bhushan \
Shah</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/onlineservices/picasa/CMakeLists.txt</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">9</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">9</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">FIND_LIBRARY</span><span class="p">(</span><span \
class="s">LibKGAPI2_LIBRARY</span> <span class="s">kgapi2</span> <span \
class="s">/usr/lib/</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't \
use find_libarary as well as never hardcode locations. Instead use find_package.. See \
L25 of plasma-mediacenter/CMakeLists.txt for example</p></pre> </blockquote>
<p>On November 2nd, 2014, 8:22 p.m. IST, <b>Ashish Bansal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Like \
this -> find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay \
because cmake is unable to find its path for me that's why I hardcoded its \
path.</p></pre> </blockquote>
<p>On November 2nd, 2014, 8:26 p.m. IST, <b>Bhushan Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">umm \
nope but like this,</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">find_package(LibKGAPI2 \
REQUIRED)</p></pre> </blockquote>
<p>On November 2nd, 2014, 8:42 p.m. IST, <b>Ashish Bansal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now, \
I am getting undefined references to all the functions and variables related to that \
Library. In ccmake,
LibKGAPI2_DIR /usr/lib64/cmake/LibKGAPI2</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">See</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">http://lxr.kde.org/source/kde/kdepim-runtime/CMakeLists.txt \
http://lxr.kde.org/source/kde/kdepim-runtime/resources/gmail/CMakeLists.txt</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">To see how it is done..</p></pre> <br />
<p>- Bhushan</p>
<br />
<p>On November 2nd, 2014, 8:47 p.m. IST, Ashish Bansal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu \
Tushar, Sinny Kumari, and Sujith Haridasan.</div> <div>By Ashish Bansal.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2014, 8:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336398">336398</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Changed auth method from Client Login to OAuth using \
libkgapi2</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything is working fine except that after \
successful login, user has to press back to view all the albums.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/onlineservices/picasa/CMakeLists.txt <span style="color: \
grey">(bd5052d)</span></li>
<li>browsingbackends/onlineservices/picasa/picasabackend.h <span style="color: \
grey">(7144dc7)</span></li>
<li>browsingbackends/onlineservices/picasa/picasabackend.cpp <span style="color: \
grey">(6317240)</span></li>
<li>browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml \
<span style="color: grey">(e8f97f7)</span></li>
<li>browsingbackends/onlineservices/picasa/picasacomponents/qmldir <span \
style="color: grey">(c790310)</span></li>
<li>browsingbackends/onlineservices/picasa/picasamodel.h <span style="color: \
grey">(5bce055)</span></li>
<li>browsingbackends/onlineservices/picasa/picasamodel.cpp <span style="color: \
grey">(2b64156)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120855/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7300591872367247972==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic