'Re: Review Request 120885: basic undo for plasmoids deletion'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120885: basic undo for plasmoids deletion
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-10-31 16:49:13
Message-ID: 20141031164913.4240.13943 () probe ! kde ! org
[Download RAW message or body]

--===============9067353400244786363==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 4:49 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-framework

Description
-------

Redone here, that seems a bit more understandable than gerrit.

It introduces a new status for applets, AwaitingDeletionStatus. triggering the delete \
action, puts the applet in AwaitingDeletionStatus. triggering it again it really \
deletes it. A notification with an undo action is emitted when the applet goes in \
AwaitingDeletionStatus.

The appelt is really deleted when either:
* A minute timeout expires
* The user manually closes the notification
* Plasma is shut down and the applet is in awaitingdeletion status

It would then be job for the qml part to actually hide applets that are \
AwaitingDeletionStatus as they don't exist anymore.

Diffs
-----

  src/scriptengines/qml/plasmoid/appletinterface.cpp 24a36b3 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp fae64c6 
  src/plasma/private/applet_p.cpp 44ecd25 
  src/scriptengines/qml/plasmoid/appletinterface.h 728eea3 
  src/plasma/data/notifications/plasmashell.notifyrc PRE-CREATION 
  src/plasma/private/applet_p.h 76a1270 
  src/plasma/applet.h 06b2722 
  src/plasma/applet.cpp f4b5410 
  CMakeLists.txt 10c0ef4 
  src/desktoptheme/breeze-dark/CMakeLists.txt d7ad680 
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svgz 102869e 
  src/plasma/CMakeLists.txt 7cc2fe3 

Diff: https://git.reviewboard.kde.org/r/120885/diff/

Testing
-------

I'm not 100% sold on the technical approach on how is done, but it seems to work \
reliably

Thanks,

Marco Martin

--===============9067353400244786363==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120885/">https://git.reviewboard.kde.org/r/120885/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2014, 4:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Redone here, that seems a bit more understandable than \
gerrit.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It introduces a new status for applets, \
AwaitingDeletionStatus. triggering the delete action, puts the applet in \
AwaitingDeletionStatus. triggering it again it really deletes it. A notification with \
an undo action is emitted when the applet goes in AwaitingDeletionStatus.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The appelt is really deleted when either: <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> A \
minute timeout expires </em> The user manually closes the notification
* Plasma is shut down and the applet is in awaitingdeletion status</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It would then be job for the qml part to actually hide \
applets that are AwaitingDeletionStatus as they don't exist anymore.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm not 100% sold on the technical approach on how is \
done, but it seems to work reliably</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(24a36b3)</span></li>

 <li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: \
grey">(fae64c6)</span></li>

 <li>src/plasma/private/applet_p.cpp <span style="color: grey">(44ecd25)</span></li>

 <li>src/scriptengines/qml/plasmoid/appletinterface.h <span style="color: \
grey">(728eea3)</span></li>

 <li>src/plasma/data/notifications/plasmashell.notifyrc <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/plasma/private/applet_p.h <span style="color: grey">(76a1270)</span></li>

 <li>src/plasma/applet.h <span style="color: grey">(06b2722)</span></li>

 <li>src/plasma/applet.cpp <span style="color: grey">(f4b5410)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(10c0ef4)</span></li>

 <li>src/desktoptheme/breeze-dark/CMakeLists.txt <span style="color: \
grey">(d7ad680)</span></li>

 <li>src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svgz <span \
style="color: grey">(102869e)</span></li>

 <li>src/plasma/CMakeLists.txt <span style="color: grey">(7cc2fe3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120885/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9067353400244786363==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 