'Re: Review Request 120891: Remove unused logout effects in KSMServer'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120891: Remove unused logout effects in KSMServer
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-10-31 15:48:05
Message-ID: 20141031154805.4239.22918 () probe ! kde ! org
[Download RAW message or body]

--===============8938116049738903475==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120891/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 3:48 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-workspace

Description
-------

Remove unused logout effects in KSMServer

KWin handles logout effects, it's not complied at the moment and it
won't ever be again.

Diffs
-----

  ksmserver/CMakeLists.txt 083c129 
  ksmserver/curtaineffect.h 32b1f37 
  ksmserver/curtaineffect.cpp 52751e8 
  ksmserver/fadeeffect.h 2bba96d 
  ksmserver/fadeeffect.cpp 3138f65 
  ksmserver/logouteffect.h 59c1aca 
  ksmserver/logouteffect.cpp cafe452 

Diff: https://git.reviewboard.kde.org/r/120891/diff/

Testing
-------

Thanks,

David Edmundson

--===============8938116049738903475==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120891/">https://git.reviewboard.kde.org/r/120891/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2014, 3:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove unused logout effects in KSMServer</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KWin handles logout effects, it's not complied at the moment and it won't \
ever be again.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/CMakeLists.txt <span style="color: grey">(083c129)</span></li>

 <li>ksmserver/curtaineffect.h <span style="color: grey">(32b1f37)</span></li>

 <li>ksmserver/curtaineffect.cpp <span style="color: grey">(52751e8)</span></li>

 <li>ksmserver/fadeeffect.h <span style="color: grey">(2bba96d)</span></li>

 <li>ksmserver/fadeeffect.cpp <span style="color: grey">(3138f65)</span></li>

 <li>ksmserver/logouteffect.h <span style="color: grey">(59c1aca)</span></li>

 <li>ksmserver/logouteffect.cpp <span style="color: grey">(cafe452)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120891/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8938116049738903475==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 