From kde-panel-devel Fri Oct 31 11:16:32 2014 From: "Marco Martin" Date: Fri, 31 Oct 2014 11:16:32 +0000 To: kde-panel-devel Subject: Re: Review Request 120913: [kcms/lnf] Make a list variable const Message-Id: <20141031111632.4240.16619 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141475420924366 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8565495152212172744==" --===============8565495152212172744== Content-Type: multipart/alternative; boundary="===============4611706001937886208==" --===============4611706001937886208== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/#review69578 ----------------------------------------------------------- Ship it! Inviala! - Marco Martin On Ott. 31, 2014, 11:13 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120913/ > ----------------------------------------------------------- > > (Updated Ott. 31, 2014, 11:13 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > The dataPath variable is used in an extended for-loop as of C++11. > As the variable was not const the for loop uses the more expensive > iterators which allow modification of the list. By making the list > const it can use the better const iterator. > > See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/ > > > Diffs > ----- > > kcms/lookandfeel/kcm.cpp a46774200c0c378485a474ff538294c7617ef6d2 > > Diff: https://git.reviewboard.kde.org/r/120913/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > > --===============4611706001937886208== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/

Ship it!

Inviala!

- Marco Martin

On ottobre 31st, 2014, 11:13 a.m. UTC, Martin Gräßlin wrote:

Review request for Plasma.

By Martin Gräßlin.

Updated Ott. 31, 2014, 11:13 a.m.

Repository: plasma-desktop

Description

The dataPath variable is used in an extended for-loop as of C++11.
As the variable was not const the for loop uses the more expensive
iterators which allow modification of the list. By making the list
const it can use the better const iterator.

See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/

Diffs

kcms/lookandfeel/kcm.cpp (a46774200c0c378485a474ff538294c7617ef6d2)

View Diff

--===============4611706001937886208==-- --===============8565495152212172744== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8565495152212172744==--