[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation
From: "Andrius da Costa Ribas" <andriusmao () gmail ! com>
Date: 2014-10-30 1:35:30
Message-ID: 20141030013530.23656.69451 () probe ! kde ! org
[Download RAW message or body]
--===============7933568161310249616==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120877/
-----------------------------------------------------------
(Updated Out. 30, 2014, 1:35 a.m.)
Review request for kdewin and Plasma.
Changes
-------
Fix coding style.
Repository: plasma-framework
Description
-------
MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as a \
compile-time const expression (error C2051: case expression not constant)
Diffs (updated)
-----
src/plasma/private/framesvg_helpers.h 5b96cd5
Diff: https://git.reviewboard.kde.org/r/120877/diff/
Testing
-------
Builds with MSVC 2013 64bit.
framesvg related tests pass, other unrelated tests still fail.
Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master
Start 1: plasma-dialogqmltest
1/10 Test #1: plasma-dialogqmltest ...............***Failed 1.15 sec
Start 2: plasma-fallbackpackagetest
2/10 Test #2: plasma-fallbackpackagetest ......... Passed 0.16 sec
Start 3: plasma-packagestructuretest
3/10 Test #3: plasma-packagestructuretest ........***Failed 0.19 sec
Start 4: plasma-packageurlinterceptortest
4/10 Test #4: plasma-packageurlinterceptortest ... Passed 0.12 sec
Start 5: plasma-pluginloadertest
5/10 Test #5: plasma-pluginloadertest ............ Passed 1.44 sec
Start 6: plasma-framesvgtest
6/10 Test #6: plasma-framesvgtest ................ Passed 0.64 sec
Start 7: coronatest
7/10 Test #7: coronatest .........................***Failed 0.16 sec
Start 8: plasma-storagetest
8/10 Test #8: plasma-storagetest .................***Failed 0.12 sec
Start 9: plasma-sortfiltermodeltest
9/10 Test #9: plasma-sortfiltermodeltest ......... Passed 0.14 sec
Start 10: i18ndcheck
Could not find executable SH-NOTFOUND
Looked in the following places:
SH-NOTFOUND
SH-NOTFOUND.exe
Release/SH-NOTFOUND
Release/SH-NOTFOUND.exe
Debug/SH-NOTFOUND
Debug/SH-NOTFOUND.exe
MinSizeRel/SH-NOTFOUND
MinSizeRel/SH-NOTFOUND.exe
RelWithDebInfo/SH-NOTFOUND
RelWithDebInfo/SH-NOTFOUND.exe
Deployment/SH-NOTFOUND
Deployment/SH-NOTFOUND.exe
Development/SH-NOTFOUND
Development/SH-NOTFOUND.exe
Unable to find executable: SH-NOTFOUND
10/10 Test #10: i18ndcheck .........................***Not Run 0.00 sec
50% tests passed, 5 tests failed out of 10
Thanks,
Andrius da Costa Ribas
--===============7933568161310249616==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120877/">https://git.reviewboard.kde.org/r/120877/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kdewin and Plasma.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Out. 30, 2014, 1:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix coding style.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">MSVC is unable to recognise e.g. FrameSvg::TopBorder | \
FrameSvg::LeftBorder as a compile-time const expression (error C2051: case expression \
not constant)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds with MSVC 2013 64bit.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">framesvg related tests pass, other unrelated tests still fail.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master \
Start 1: plasma-dialogqmltest 1/10 Test #1: plasma-dialogqmltest \
...............<strong style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Failed 1.15 sec \
Start 2: plasma-fallbackpackagetest 2/10 Test #2: plasma-fallbackpackagetest \
......... Passed 0.16 sec Start 3: plasma-packagestructuretest
3/10 Test #3: plasma-packagestructuretest ........</em></strong>Failed 0.19 sec
Start 4: plasma-packageurlinterceptortest
4/10 Test #4: plasma-packageurlinterceptortest ... Passed 0.12 sec
Start 5: plasma-pluginloadertest
5/10 Test #5: plasma-pluginloadertest ............ Passed 1.44 sec
Start 6: plasma-framesvgtest
6/10 Test #6: plasma-framesvgtest ................ Passed 0.64 sec
Start 7: coronatest
7/10 Test #7: coronatest .........................<strong style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Failed 0.16 sec Start 8: plasma-storagetest
8/10 Test #8: plasma-storagetest .................</em></strong>Failed 0.12 sec
Start 9: plasma-sortfiltermodeltest
9/10 Test #9: plasma-sortfiltermodeltest ......... Passed 0.14 sec
Start 10: i18ndcheck
Could not find executable SH-NOTFOUND
Looked in the following places:
SH-NOTFOUND
SH-NOTFOUND.exe
Release/SH-NOTFOUND
Release/SH-NOTFOUND.exe
Debug/SH-NOTFOUND
Debug/SH-NOTFOUND.exe
MinSizeRel/SH-NOTFOUND
MinSizeRel/SH-NOTFOUND.exe
RelWithDebInfo/SH-NOTFOUND
RelWithDebInfo/SH-NOTFOUND.exe
Deployment/SH-NOTFOUND
Deployment/SH-NOTFOUND.exe
Development/SH-NOTFOUND
Development/SH-NOTFOUND.exe
Unable to find executable: SH-NOTFOUND
10/10 Test #10: i18ndcheck .........................***Not Run 0.00 sec</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">50% tests passed, 5 tests failed out of 10</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/private/framesvg_helpers.h <span style="color: \
grey">(5b96cd5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120877/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7933568161310249616==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic