[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120894: Forward wheel events inside panelview
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-10-29 20:17:38
Message-ID: 20141029201738.23656.57382 () probe ! kde ! org
[Download RAW message or body]
--===============4957126810763382643==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Ott. 29, 2014, 7:55 p.m., Marco Martin wrote:
> > shell/panelview.cpp, line 688
> > <https://git.reviewboard.kde.org/r/120894/diff/1/?file=323565#file323565line688>
> >
> > would be cleaner to put it in its own case, instead of grouped together with the \
> > mouse events, since is completely separed anyways
>
> Kai Uwe Broulik wrote:
> QWheelEvent doesn't have a windowPos() which is why I put it in there. Or should I \
> make a separate case and have a cast to QMouseEvent and QWheelEvent there?
It has globalPos() that can be used.
the fact that you are casting the event both to wheelevent and mouseevent seems to be \
quite by chance that's not crashing, since a wheelevent is not a mouseevent subclass \
(but just inputevent common ancestor)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120894/#review69482
-----------------------------------------------------------
On Ott. 29, 2014, 7:33 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120894/
> -----------------------------------------------------------
>
> (Updated Ott. 29, 2014, 7:33 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 340412
> https://bugs.kde.org/show_bug.cgi?id=340412
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This makes it also forward wheel events in the same fashion as it does with clicks. \
> Restores Fitt's law for taskmanager wheeling. A similar patch for plasma-frameworks \
> dialog is needed as well.
>
> Diffs
> -----
>
> shell/panelview.cpp 2bece00
>
> Diff: https://git.reviewboard.kde.org/r/120894/diff/
>
>
> Testing
> -------
>
> Throw your mouse to the edge where your taskmanager is and wheel. Works as \
> expected.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============4957126810763382643==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120894/">https://git.reviewboard.kde.org/r/120894/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On ottobre 29th, 2014, 7:55 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120894/diff/1/?file=323565#file323565line688" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/panelview.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
PanelView::event(QEvent *e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">688</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">e</span><span \
class="o">-></span><span class="n">type</span><span class="p">()</span> <span \
class="o">==</span> <span class="n">QEvent</span><span class="o">::</span><span \
class="n">Wheel</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">would \
be cleaner to put it in its own case, instead of grouped together with the mouse \
events, since is completely separed anyways</p></pre> </blockquote>
<p>On ottobre 29th, 2014, 8:10 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">QWheelEvent doesn't have a windowPos() which is why I put it in there. Or \
should I make a separate case and have a cast to QMouseEvent and QWheelEvent \
there?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It has globalPos() that can be used.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
fact that you are casting the event both to wheelevent and mouseevent seems to be \
quite by chance that's not crashing, since a wheelevent is not a mouseevent subclass \
(but just inputevent common ancestor)</p></pre> <br />
<p>- Marco</p>
<br />
<p>On ottobre 29th, 2014, 7:33 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Ott. 29, 2014, 7:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=340412">340412</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This makes it also forward wheel events in the same \
fashion as it does with clicks. Restores Fitt's law for taskmanager wheeling. A \
similar patch for plasma-frameworks dialog is needed as well.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Throw your mouse to the edge where your taskmanager is \
and wheel. Works as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/panelview.cpp <span style="color: grey">(2bece00)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120894/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4957126810763382643==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic