[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2014-10-29 18:23:06
Message-ID: 20141029182306.23656.42951 () probe ! kde ! org
[Download RAW message or body]
--===============3287443922892700296==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 6:23 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and David Edmundson.
Repository: kdeplasma-addons
Description
-------
Config options from previous c++ version kept though names are a bit diferent.
Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the corner though.
This is my first port to plasma qml, so I may have used some of the non suggested/recommended \
components, if so let me know and I'll fix it.
Diffs
-----
applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592
applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124
applets/fifteenPuzzle/Messages.sh PRE-CREATION
applets/fifteenPuzzle/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d
applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz
applets/fifteenPuzzle/images/blanksquare.svg
applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION
applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION
applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION
applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION
applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION
applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION
applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION
applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop \
513cc0084df7247a520807620361b0426623727e applets/fifteenPuzzle/src/Messages.sh \
bab24ae73049f37d9693cf062eaaa98ca1e6bab0 applets/fifteenPuzzle/src/fifteen.h \
2a27f5b109988003de45fb64c457484ebdfdbc8b applets/fifteenPuzzle/src/fifteen.cpp \
ebdcf2c0756a17ea174c0fc5fd106e157b223063 applets/fifteenPuzzle/src/fifteenPuzzle.h \
cf7885380f0e152d51cf2dc7557444e9b425b596 applets/fifteenPuzzle/src/fifteenPuzzle.cpp \
8a1528988f3e693d20179db4a209309b0aad87fd applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui \
ff82f331db4cee2d66f526954be63f0f5d81d250 applets/fifteenPuzzle/src/piece.h \
d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 applets/fifteenPuzzle/src/piece.cpp \
2efb72ecf69d9beaa53367bc2f3c9cee88238f28 \
applets/systemloadviewer/package/contents/ui/ColorPicker.qml \
92062db546dcff67f930d4888180f4e753798c27
Diff: https://git.reviewboard.kde.org/r/120806/diff/
Testing
-------
I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle.
The icon is not working in the widget adder, not sure where to install that to for it to work.
Images not supported yet, though they are in the config, maybe should remove from config until \
they are supported?
Thanks,
Jeremy Whiting
--===============3287443922892700296==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120806/">https://git.reviewboard.kde.org/r/120806/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2014, 6:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Config options \
from previous c++ version kept though names are a bit diferent. Images not yet supported.
Puzzle starts at 0 in the top left corner, maybe should start with 1 in the corner though.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This is my first port to plasma qml, so I may have used some of the non \
suggested/recommended components, if so let me know and I'll fix it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've tested it \
with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The icon is not working in the \
widget adder, not sure where to install that to for it to work. Images not supported yet, \
though they are in the config, maybe should remove from config until they are \
supported?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: \
grey">(63e6e25628d18ee474231acd2a21711841dee592)</span></li>
<li>applets/fifteenPuzzle/CMakeLists.txt <span style="color: \
grey">(04d5e55fd246684855d49484f1233dac054a0124)</span></li>
<li>applets/fifteenPuzzle/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/icons/CMakeLists.txt <span style="color: \
grey">(106884f432c1d1e0b0584959af854c79ede4ea6d)</span></li>
<li>applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz <span style="color: \
grey">()</span></li>
<li>applets/fifteenPuzzle/images/blanksquare.svg <span style="color: grey">()</span></li>
<li>applets/fifteenPuzzle/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/package/contents/config/main.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/Piece.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/configAppearance.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop <span style="color: \
grey">(513cc0084df7247a520807620361b0426623727e)</span></li>
<li>applets/fifteenPuzzle/src/Messages.sh <span style="color: \
grey">(bab24ae73049f37d9693cf062eaaa98ca1e6bab0)</span></li>
<li>applets/fifteenPuzzle/src/fifteen.h <span style="color: \
grey">(2a27f5b109988003de45fb64c457484ebdfdbc8b)</span></li>
<li>applets/fifteenPuzzle/src/fifteen.cpp <span style="color: \
grey">(ebdcf2c0756a17ea174c0fc5fd106e157b223063)</span></li>
<li>applets/fifteenPuzzle/src/fifteenPuzzle.h <span style="color: \
grey">(cf7885380f0e152d51cf2dc7557444e9b425b596)</span></li>
<li>applets/fifteenPuzzle/src/fifteenPuzzle.cpp <span style="color: \
grey">(8a1528988f3e693d20179db4a209309b0aad87fd)</span></li>
<li>applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui <span style="color: \
grey">(ff82f331db4cee2d66f526954be63f0f5d81d250)</span></li>
<li>applets/fifteenPuzzle/src/piece.h <span style="color: \
grey">(d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1)</span></li>
<li>applets/fifteenPuzzle/src/piece.cpp <span style="color: \
grey">(2efb72ecf69d9beaa53367bc2f3c9cee88238f28)</span></li>
<li>applets/systemloadviewer/package/contents/ui/ColorPicker.qml <span style="color: \
grey">(92062db546dcff67f930d4888180f4e753798c27)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120806/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3287443922892700296==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic