[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120891: Remove unused logout effects in KSMServer
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-10-29 17:37:34
Message-ID: 20141029173734.23656.50510 () probe ! kde ! org
[Download RAW message or body]
--===============0594076161034063077==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120891/#review69473
-----------------------------------------------------------
Ship it!
+1 that's in the category of "world cultural heritage code"
- Marco Martin
On Ott. 29, 2014, 5:14 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120891/
> -----------------------------------------------------------
>
> (Updated Ott. 29, 2014, 5:14 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Remove unused logout effects in KSMServer
>
> KWin handles logout effects, it's not complied at the moment and it
> won't ever be again.
>
>
> Diffs
> -----
>
> ksmserver/CMakeLists.txt 083c129
> ksmserver/curtaineffect.h 32b1f37
> ksmserver/curtaineffect.cpp 52751e8
> ksmserver/fadeeffect.h 2bba96d
> ksmserver/fadeeffect.cpp 3138f65
> ksmserver/logouteffect.h 59c1aca
> ksmserver/logouteffect.cpp cafe452
>
> Diff: https://git.reviewboard.kde.org/r/120891/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============0594076161034063077==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120891/">https://git.reviewboard.kde.org/r/120891/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 \
that's in the category of "world cultural heritage code"</p></pre> <br />
<p>- Marco Martin</p>
<br />
<p>On ottobre 29th, 2014, 5:14 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Ott. 29, 2014, 5:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove unused logout effects in KSMServer</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KWin handles logout effects, it's not complied at the moment and it won't \
ever be again.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/CMakeLists.txt <span style="color: grey">(083c129)</span></li>
<li>ksmserver/curtaineffect.h <span style="color: grey">(32b1f37)</span></li>
<li>ksmserver/curtaineffect.cpp <span style="color: grey">(52751e8)</span></li>
<li>ksmserver/fadeeffect.h <span style="color: grey">(2bba96d)</span></li>
<li>ksmserver/fadeeffect.cpp <span style="color: grey">(3138f65)</span></li>
<li>ksmserver/logouteffect.h <span style="color: grey">(59c1aca)</span></li>
<li>ksmserver/logouteffect.cpp <span style="color: grey">(cafe452)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120891/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0594076161034063077==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic