[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109832: New tabbox layout with scaling thumbnails
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-10-29 15:46:31
Message-ID: 20141029154631.23655.13303 () probe ! kde ! org
[Download RAW message or body]
--===============5871444200786556195==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> >
>
> Martin Gräßlin wrote:
> @Kai Uwe: may I ask you to do such a review for all other existing window \
> switchers? Or just have a look at them and improve as you seem fit.
Okay, once they've all landed in kdeplasma-addons I will take a look.
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, lines 375-376
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line375>
> >
> > Could this be done in a declarative, rather than imperative, way?
>
> Andre Heinecke wrote:
> I use both functions more then once.
> If i did it declartively I had to duplicate the code, right?
I was more thinking of something like
width: Math.min(textItem.contentWidth, scalingTabBox.width - \
captionFrame.anchors.leftMargin - captionFrame.anchors.rightMargin - \
captionIconItem.width * 2 - captionFrame.anchors.rightMargin)
instead of manually invoking that method whenever the width or text changes and let \
QML figure that out for us automagically.
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, line 405
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line405>
> >
> > i18n this?
>
> Andre Heinecke wrote:
> I don't think this is neccessary. The braces are just used to indicate that a \
> window is minimized. They have no lingustic meaning in this context.
You cannot assume that a language uses exactly this kind of braces in that order:
i18nc("braces just denote the window is minimized", "(%1)", text)
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, line 163
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line163>
> >
> > Doesn't have a height
>
> Andre Heinecke wrote:
> The height is assigned in the states.
> Is there an advantage to set one initially?
Sorry, I missed that. Fine then.
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, line 147
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line147>
> >
> > Is the lagging behind highlight really needed? :/
>
> Andre Heinecke wrote:
> I find 250 looks smooth enough. And it's the same as all other window tabbox \
> plugins use so I would also prefer to use the same value here. Longer and it gets \
> sluggish. Shorter and it looks "jumpy".
Right, we need to ask VDG/HIG about that later then.
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, line 132
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line132>
> >
> > Then use FrameSvg not FrameSvgItem
>
> Andre Heinecke wrote:
> Not sure what you mean here. Should I just take the margins from FrameSvg as the \
> margins of the hover effect? I understood this code to create a hover item to get \
> the margins of that item. (Taken over from Thumbnails)
I just forwarded that comment from David who complained about that in a different RR \
:)
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, line 79
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line79>
> >
> > Be careful with clipping, it's quite expensive
>
> Andre Heinecke wrote:
> Not sure why there is clipping here. I took this over from thumbnails layout and \
> thought it would be there for a reason. Removed now.
Fair enough. Needs investigation/fixing in the others as well, Martin G said it might \
be needed by KWin internally.
> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, line 36
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line36>
> >
> > Don't hardcode sizes, use units.gridUnit et al
> >
> > You also might want to make those properties readonly
>
> Andre Heinecke wrote:
> I've changed all hardcoded values (there were some hardcoded 5's where i meant icon \
> spacing) to use properties and the basic size properties are now based on units.
5 could be units.smallSpacing or so I guess
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109832/#review69422
-----------------------------------------------------------
On Okt. 29, 2014, 3:22 nachm., Andre Heinecke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109832/
> -----------------------------------------------------------
>
> (Updated Okt. 29, 2014, 3:22 nachm.)
>
>
> Review request for kwin, Plasma and Martin Gräßlin.
>
>
> Bugs: 292566
> http://bugs.kde.org/show_bug.cgi?id=292566
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> I'm reopening this review request as I have updated this Window Switcher for Plasma \
> 5.1 and would like to get another review to check if there are any suggestions or \
> issues regarding the port to the new API.
> Secondly I would like to ask again to have this Window Switcher Layout included in \
> the KWin repository. I would prefer it if users could obtain this layout from their \
> trusted distributors and did not have to rely on an unverifyable third party \
> download to obtain this plugin.
> As suggested in the original review I've put this up on kde-look and recieved some \
> positive feedback. But I really feel that it is rotting away there and that \
> KDE-Look is not a good place to distribute executable plugins.
> IMHO the approach of this Window Switcher is different enough from the others \
> included in KWin to be a useful addition to the fold. Especially as this behavior \
> is already familiar to KDE users from some versions < 4.6
> It should also be close enough to the other layouts like thumbnails to keep \
> maintenance very similar (I've mostly looked at the changes made to thumbnails to \
> adapt this for Plasma 5)
>
> Original description:
>
> This Layout tries to mimic some of the old KDE 4.6 tabbox behavior and layout, it \
> scales the thumbnails shown in the tabbox to avoid scrolling. There are also three \
> different states in this layout depending on the size of the scaled thumbnails to \
> provide appropriate information even when there are many opened windows.
> States:
> 1. Thumbnails are larger then 200px: Show the Title and the Icon of the Window \
> directly below the thumbnail. 2. Thumbnails are between 200px and 64px: Thumbnails \
> are shown together with the icon but only the title of the currently selected \
> window is shown. 3. Thumbnails would be smaller then 64px: Only the Icons of the \
> windows are shown and the title of the currently selected window (like big icons) \
> If the Thumbnails would be smaller then 32px the tabbox starts to scroll in the \
> Icon Only state.
> Size of the thumbnails depends on the screen size and the number of opened windows.
>
>
> Diffs
> -----
>
> tabbox/qml/CMakeLists.txt fc55ab9
> tabbox/qml/clients/scaling/contents/ui/main.qml PRE-CREATION
> tabbox/qml/clients/scaling/metadata.desktop PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/109832/diff/
>
>
> Testing
> -------
>
> Tested with plasma 5.3.1 from Kubuntu next / unstable repositories.
>
>
> Thanks,
>
> Andre Heinecke
>
>
--===============5871444200786556195==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109832/">https://git.reviewboard.kde.org/r/109832/</a>
</td>
</tr>
</table>
<br />
<p>On Oktober 29th, 2014, 1:15 nachm. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Kai \
Uwe: may I ask you to do such a review for all other existing window switchers? Or \
just have a look at them and improve as you seem fit.</p></pre> </blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Okay, \
once they've all landed in kdeplasma-addons I will take a look.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 11:57 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">captionDelegateHeight:</span> <span class="mi">40</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't \
hardcode sizes, use units.gridUnit et al</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">You also might want to \
make those properties readonly</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 2:20 nachm. UTC, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've \
changed all hardcoded values (there were some hardcoded 5's where i meant icon \
spacing) to use properties and the basic size properties are now based on \
units.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">5 could be units.smallSpacing or so I guess</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 11:57 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line79" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">clip:</span> <span class="kc">true</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Be \
careful with clipping, it's quite expensive</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 2:20 nachm. UTC, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not \
sure why there is clipping here. I took this over from thumbnails layout and thought \
it would be there for a reason. Removed now.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fair enough. Needs investigation/fixing in the others as well, Martin G \
said it might be needed by KWin internally.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 11:57 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line132" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">132</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// just to get the margin sizes</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Then \
use FrameSvg not FrameSvgItem</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 2:20 nachm. UTC, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not \
sure what you mean here. Should I just take the margins from FrameSvg as the margins \
of the hover effect? I understood this code to create a hover item to get the margins \
of that item. (Taken over from Thumbnails)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I just forwarded that comment from David who complained about that in a \
different RR :)</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 11:57 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">147</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">highlightMoveDuration:</span> <span class="mi">250</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is \
the lagging behind highlight really needed? :/</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 2:20 nachm. UTC, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
find 250 looks smooth enough. And it's the same as all other window tabbox plugins \
use so I would also prefer to use the same value here. Longer and it gets sluggish. \
Shorter and it looks "jumpy".</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Right, we need to ask VDG/HIG about that later then.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 11:57 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line163" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">163</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">width:</span> <span class="nx">scalingTabBox</span><span \
class="p">.</span><span class="nx">fittingThumbsWidth</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Doesn't have a height</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 2:20 nachm. UTC, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
height is assigned in the states. Is there an advantage to set one \
initially?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sorry, I missed that. Fine then.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 11:57 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line375" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">375</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">textItem</span><span class="p">.</span><span \
class="nx">calculateMaxWidth</span><span class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">376</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">textItem</span><span class="p">.</span><span \
class="nx">constrainWidth</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could \
this be done in a declarative, rather than imperative, way?</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 2:20 nachm. UTC, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I use \
both functions more then once. If i did it declartively I had to duplicate the code, \
right?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I was more thinking of something like</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">width: Math.min(textItem.contentWidth, scalingTabBox.width - \
captionFrame.anchors.leftMargin - captionFrame.anchors.rightMargin - \
captionIconItem.width * 2 - captionFrame.anchors.rightMargin)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">instead of manually invoking that method whenever the width or text changes \
and let QML figure that out for us automagically.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 11:57 vorm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line405" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tabbox/qml/clients/scaling/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">405</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">text</span> <span class="o">=</span> <span \
class="s2">"("</span> <span class="o">+</span> <span class="nx">text</span> \
<span class="o">+</span> <span class="s2">")"</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i18n \
this?</p></pre> </blockquote>
<p>On Oktober 29th, 2014, 2:20 nachm. UTC, <b>Andre Heinecke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think this is neccessary. The braces are just used to indicate that a window is \
minimized. They have no lingustic meaning in this context.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">You cannot assume that a language uses exactly this kind of braces in that \
order: i18nc("braces just denote the window is minimized", "(%1)", text)</p></pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On Oktober 29th, 2014, 3:22 nachm. UTC, Andre Heinecke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin, Plasma and Martin Gräßlin.</div>
<div>By Andre Heinecke.</div>
<p style="color: grey;"><i>Updated Okt. 29, 2014, 3:22 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=292566">292566</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm reopening this review request as I have updated \
this Window Switcher for Plasma 5.1 and would like to get another review to check if \
there are any suggestions or issues regarding the port to the new API.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Secondly I would like to ask again to have this Window Switcher Layout \
included in the KWin repository. I would prefer it if users could obtain this layout \
from their trusted distributors and did not have to rely on an unverifyable third \
party download to obtain this plugin. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">As suggested in the \
original review I've put this up on kde-look and recieved some positive feedback. But \
I really feel that it is rotting away there and that KDE-Look is not a good place to \
distribute executable plugins.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">IMHO the approach of \
this Window Switcher is different enough from the others included in KWin to be a \
useful addition to the fold. Especially as this behavior is already familiar to KDE \
users from some versions < 4.6</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It should also be close \
enough to the other layouts like thumbnails to keep maintenance very similar (I've \
mostly looked at the changes made to thumbnails to adapt this for Plasma 5)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Original description:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This Layout tries to \
mimic some of the old KDE 4.6 tabbox behavior and layout, it scales the thumbnails \
shown in the tabbox to avoid scrolling. There are also three different states in this \
layout depending on the size of the scaled thumbnails to provide appropriate \
information even when there are many opened windows.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">States: 1. Thumbnails are larger then 200px: Show the Title and the Icon of \
the Window directly below the thumbnail. 2. Thumbnails are between 200px and 64px: \
Thumbnails are shown together with the icon but only the title of the currently \
selected window is shown. 3. Thumbnails would be smaller then 64px: Only the Icons of \
the windows are shown and the title of the currently selected window (like big icons) \
If the Thumbnails would be smaller then 32px the tabbox starts to scroll in the Icon \
Only state.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Size of the thumbnails depends on the screen size and \
the number of opened windows.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with plasma 5.3.1 from Kubuntu next / unstable \
repositories.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tabbox/qml/CMakeLists.txt <span style="color: grey">(fc55ab9)</span></li>
<li>tabbox/qml/clients/scaling/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tabbox/qml/clients/scaling/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109832/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5871444200786556195==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic