[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla"
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-10-29 12:43:49
Message-ID: 20141029124349.23656.20615 () probe ! kde ! org
[Download RAW message or body]
--===============3216968257391864609==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote:
> > The version check is actually on the bugzilla version (KDE_MAKE_VERSION is just a \
> > bitshifting macro) - it's the important part in the original patch ;-)
To prevent future confusion, one might want to add
#define KDE_MAKE_BUGZILLA_VERSION KDE_MAKE_VERSION
or sth. like this.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120876/#review69429
-----------------------------------------------------------
On Okt. 28, 2014, 11:02 nachm., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120876/
> -----------------------------------------------------------
>
> (Updated Okt. 28, 2014, 11:02 nachm.)
>
>
> Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking.
>
>
> Bugs: 337742
> https://bugs.kde.org/show_bug.cgi?id=337742
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> discussion was in https://git.reviewboard.kde.org/r/120431/
> removed the version checks, as we know we have kdelibs >= 4.5 ;-)
>
>
> Diffs
> -----
>
> drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f
> drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f
> drkonqi/bugzillaintegration/bugzillalib.h 570169b
> drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399
>
> Diff: https://git.reviewboard.kde.org/r/120876/diff/
>
>
> Testing
> -------
>
> builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============3216968257391864609==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120876/">https://git.reviewboard.kde.org/r/120876/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 29th, 2014, 12:41 nachm. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The version check is actually on the bugzilla version \
(KDE_MAKE_VERSION is just a bitshifting macro) - it's the important part in the \
original patch ;-)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To \
prevent future confusion, one might want to add</p> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">define KDE_MAKE_BUGZILLA_VERSION KDE_MAKE_VERSION</h1> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">or \
sth. like this.</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On Oktober 28th, 2014, 11:02 nachm. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Okt. 28, 2014, 11:02 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=337742">337742</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">discussion was in \
https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we \
have kdelibs >= 4.5 ;-)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds, succesfully reported bug via patched DrKonqi, \
wasn't able to do so before.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h <span style="color: \
grey">(50cf05f)</span></li>
<li>drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp <span \
style="color: grey">(5a6096f)</span></li>
<li>drkonqi/bugzillaintegration/bugzillalib.h <span style="color: \
grey">(570169b)</span></li>
<li>drkonqi/bugzillaintegration/bugzillalib.cpp <span style="color: \
grey">(8fd8399)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120876/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3216968257391864609==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic