[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120885: basic undo for plasmoids deletion
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-10-29 9:44:06
Message-ID: 20141029094406.23656.34333 () probe ! kde ! org
[Download RAW message or body]
--===============4285347016043201268==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 29, 2014, 9:39 a.m., Kai Uwe Broulik wrote:
> > src/plasma/private/applet_p.cpp, line 240
> > <https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line240>
> >
> > The notification should have the plasmoid icon, no?
indeed. knotification doesn't have api for just icons, just possible to set a \
qpixmap. what i'm concerned is that taking the icon pixmap may end up with a bad \
scaling if the view has a different size
> On Oct. 29, 2014, 9:39 a.m., Kai Uwe Broulik wrote:
> > src/plasma/private/applet_p.cpp, line 272
> > <https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line272>
> >
> > Does removing notifications actually work with our current notification plasmoid?
yep
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69387
-----------------------------------------------------------
On Oct. 29, 2014, 9:28 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120885/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 9:28 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Redone here, that seems a bit more understandable than gerrit.
>
> It introduces a new status for applets, AwaitingDeletionStatus. triggering the \
> delete action, puts the applet in AwaitingDeletionStatus. triggering it again it \
> really deletes it. A notification with an undo action is emitted when the applet \
> goes in AwaitingDeletionStatus.
> The appelt is really deleted when either:
> * A minute timeout expires
> * The user manually closes the notification
> * Plasma is shut down and the applet is in awaitingdeletion status
>
> It would then be job for the qml part to actually hide applets that are \
> AwaitingDeletionStatus as they don't exist anymore.
>
> Diffs
> -----
>
> src/plasma/plasma.h 15c346b
> src/plasma/private/applet_p.h 76a1270
> src/plasma/private/applet_p.cpp 44ecd25
> src/plasma/private/containment_p.cpp 3836772
> src/scriptengines/qml/plasmoid/appletinterface.cpp 24a36b3
> src/scriptengines/qml/plasmoid/containmentinterface.cpp fae64c6
> CMakeLists.txt 10c0ef4
> src/plasma/CMakeLists.txt 7cc2fe3
> src/plasma/applet.cpp f4b5410
> src/plasma/data/notifications/plasmashell.notifyrc PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120885/diff/
>
>
> Testing
> -------
>
> I'm not 100% sold on the technical approach on how is done, but it seems to work \
> reliably
>
> Thanks,
>
> Marco Martin
>
>
--===============4285347016043201268==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120885/">https://git.reviewboard.kde.org/r/120885/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 29th, 2014, 9:39 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line240" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/private/applet_p.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
AppletPrivate::showConfigurationRequiredMessage(bool show, const QString \
&reason)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">234</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QObject</span><span class="o">::</span><span class="n">connect</span><span \
class="p">(</span><span class="n">box</span><span class="o">-></span><span \
class="n">button</span><span class="p">(</span><span \
class="n">QMessageBox</span><span class="o">::</span><span class="n">Yes</span><span \
class="p">),</span> <span class="o">&</span><span \
class="n">QAbstractButton</span><span class="o">::</span><span \
class="n">clicked</span><span class="p">,</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">240</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">deleteNotification</span><span class="o">-></span><span \
class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"The widget </span><span \
class="se">\"</span><span class="s">%1</span><span \
class="se">\"</span><span class="s"> has been deleted."</span><span \
class="p">,</span> <span class="n">q</span><span class="o">-></span><span \
class="n">title</span><span class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
notification should have the plasmoid icon, no?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">indeed. knotification doesn't have api for just icons, just possible to set \
a qpixmap. what i'm concerned is that taking the icon pixmap may end up with a bad \
scaling if the view has a different size</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 29th, 2014, 9:39 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line272" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/private/applet_p.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
AppletPrivate::showConfigurationRequiredMessage(bool show, const QString \
&reason)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">272</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">deleteNotification</span><span class="o">-></span><span \
class="n">close</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does \
removing notifications actually work with our current notification \
plasmoid?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">yep</p></pre> <br />
<p>- Marco</p>
<br />
<p>On October 29th, 2014, 9:28 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2014, 9:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Redone here, that seems a bit more understandable than \
gerrit.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It introduces a new status for applets, \
AwaitingDeletionStatus. triggering the delete action, puts the applet in \
AwaitingDeletionStatus. triggering it again it really deletes it. A notification with \
an undo action is emitted when the applet goes in AwaitingDeletionStatus.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The appelt is really deleted when either: <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> A \
minute timeout expires </em> The user manually closes the notification
* Plasma is shut down and the applet is in awaitingdeletion status</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It would then be job for the qml part to actually hide \
applets that are AwaitingDeletionStatus as they don't exist anymore.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm not 100% sold on the technical approach on how is \
done, but it seems to work reliably</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/plasma.h <span style="color: grey">(15c346b)</span></li>
<li>src/plasma/private/applet_p.h <span style="color: grey">(76a1270)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(44ecd25)</span></li>
<li>src/plasma/private/containment_p.cpp <span style="color: \
grey">(3836772)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(24a36b3)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: \
grey">(fae64c6)</span></li>
<li>CMakeLists.txt <span style="color: grey">(10c0ef4)</span></li>
<li>src/plasma/CMakeLists.txt <span style="color: grey">(7cc2fe3)</span></li>
<li>src/plasma/applet.cpp <span style="color: grey">(f4b5410)</span></li>
<li>src/plasma/data/notifications/plasmashell.notifyrc <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120885/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4285347016043201268==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic