From kde-panel-devel Wed Oct 29 02:27:06 2014 From: "Andrius da Costa Ribas" Date: Wed, 29 Oct 2014 02:27:06 +0000 To: kde-panel-devel Subject: Review Request 120878: Remove unused header Message-Id: <20141029022706.23656.66110 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141454966922592 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7133404364432371970==" --===============7133404364432371970== Content-Type: multipart/alternative; boundary="===============7807392313591859762==" --===============7807392313591859762== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ ----------------------------------------------------------- Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description ------- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs ----- src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing ------- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas --===============7807392313591859762== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/

Review request for KDE Frameworks, kdewin and Plasma.

By Andrius da Costa Ribas.

Repository: krunner

Description

Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript.

Testing

Tested building using MSVC 64bit

Diffs

src/abstractrunner.cpp (4da0394)

View Diff

--===============7807392313591859762==-- --===============7133404364432371970== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7133404364432371970==--