[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120850: Move KWin's window switcher "sidebar" to Look'n'Feel package
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-10-28 17:06:05
Message-ID: 20141028170605.23655.49523 () probe ! kde ! org
[Download RAW message or body]
--===============7451894554400715348==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Oct. 28, 2014, 5:26 p.m., Marco Martin wrote:
> > Still related to the comment of the previous review request..
> > If the l&f package actually provides the qml files of the switcher, kindof \
> > removes the point of the defaults file... or is it still possible to set a \
> > different switcxher in the kwin config? in this case this patch is fine, provided \
> > all the other switchers to be in the same package format
> or is it still possible to set a different switcxher in the kwin config?
yes. Though the configuration module needs adjustment. That it's still possible to \
configure another switcher can be seen in https://git.reviewboard.kde.org/r/120849/
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120850/#review69304
-----------------------------------------------------------
On Oct. 28, 2014, 4:55 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120850/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 4:55 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Move KWin's window switcher "sidebar" to Look'n'Feel package
>
>
> Diffs
> -----
>
> lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b
> lookandfeel/contents/windowswitcher/WindowSwitcher.qml \
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> Diff: https://git.reviewboard.kde.org/r/120850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============7451894554400715348==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120850/">https://git.reviewboard.kde.org/r/120850/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 28th, 2014, 5:26 p.m. CET, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Still related to the comment of the previous review \
request.. If the l&f package actually provides the qml files of the switcher, \
kindof removes the point of the defaults file... or is it still possible to set a \
different switcxher in the kwin config? in this case this patch is fine, provided all \
the other switchers to be in the same package format</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">or is it still possible to set a different switcxher in the kwin \
config?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">yes. Though the configuration module needs adjustment. \
That it's still possible to configure another switcher can be seen in \
https://git.reviewboard.kde.org/r/120849/</p></pre> <br />
<p>- Martin</p>
<br />
<p>On October 28th, 2014, 4:55 p.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2014, 4:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Move KWin's window switcher "sidebar" to \
Look'n'Feel package</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/defaults <span style="color: \
grey">(1dfe182e305f0a4ca2e0daad56a581efd68b930b)</span></li>
<li>lookandfeel/contents/windowswitcher/WindowSwitcher.qml <span style="color: \
grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120850/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7451894554400715348==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic