[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-10-28 11:25:58
Message-ID: 20141028112558.23655.62913 () probe ! kde ! org
[Download RAW message or body]
--===============1818761770445098098==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120842/#review69255
-----------------------------------------------------------
kcmkwin/kwincompositing/qml/Effect.qml
<https://git.reviewboard.kde.org/r/120842/#comment48414>
You can just set the Loader's active property instead of messing with the source.
kcmkwin/kwincompositing/qml/Effect.qml
<https://git.reviewboard.kde.org/r/120842/#comment48415>
onLoaded: {}
- Kai Uwe Broulik
On Okt. 28, 2014, 10:29 vorm., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120842/
> -----------------------------------------------------------
>
> (Updated Okt. 28, 2014, 10:29 vorm.)
>
>
> Review request for kwin, Plasma and Martin Klapetek.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> Currently just opening the Desktop Effects KCM loads QtMultimedia which
> in turn loads gstreamer 0.10. If one opens any other KCM in
> systemsettings and changes without applying the change, the window
> freezes when the warning dialog gets shown, because the warning message
> pulls in Phonon with maybe the Gstreamer backend which uses
> gstreamer 1.0. This is bad, bad and breaks everything.
>
> By using a Loader the problem scope gets reduced. It still happens but
> only if one actually watches a video. Only opening the KCM doesn't
> trigger the problem any more.
>
>
> Diffs
> -----
>
> kcmkwin/kwincompositing/qml/Effect.qml a2a003cc33e99cc8881fb7fd149a56684e6d3a4d
> kcmkwin/kwincompositing/qml/Video.qml c217eb44fa60fab276dd0fe5ff86fd726a26ea7d
>
> Diff: https://git.reviewboard.kde.org/r/120842/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============1818761770445098098==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120842/">https://git.reviewboard.kde.org/r/120842/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120842/diff/1/?file=322447#file322447line128" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcmkwin/kwincompositing/qml/Effect.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">128</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">videoItem</span><span class="p">.</span><span \
class="nx">source</span> <span class="o">=</span> <span \
class="s2">"Video.qml"</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
can just set the Loader's active property instead of messing with the \
source.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120842/diff/1/?file=322447#file322447line133" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcmkwin/kwincompositing/qml/Effect.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">133</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">onStatusChanged:</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">onLoaded: {}</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Oktober 28th, 2014, 10:29 vorm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin, Plasma and Martin Klapetek.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Okt. 28, 2014, 10:29 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently just opening the Desktop Effects KCM loads QtMultimedia which \
in turn loads gstreamer 0.10. If one opens any other KCM in systemsettings and \
changes without applying the change, the window freezes when the warning dialog gets \
shown, because the warning message pulls in Phonon with maybe the Gstreamer backend \
which uses gstreamer 1.0. This is bad, bad and breaks everything.
By using a Loader the problem scope gets reduced. It still happens but
only if one actually watches a video. Only opening the KCM doesn't
trigger the problem any more.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcmkwin/kwincompositing/qml/Effect.qml <span style="color: \
grey">(a2a003cc33e99cc8881fb7fd149a56684e6d3a4d)</span></li>
<li>kcmkwin/kwincompositing/qml/Video.qml <span style="color: \
grey">(c217eb44fa60fab276dd0fe5ff86fd726a26ea7d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120842/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1818761770445098098==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic