'Re: Review Request 120778: Only show the list of hidden system tray items when a hidden item is expa'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120778: Only show the list of hidden system tray items when a hidden item is expa
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-10-27 12:16:48
Message-ID: 20141027121648.23656.60866 () probe ! kde ! org
[Download RAW message or body]

--===============5526378571436659808==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120778/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 12:16 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-workspace

Description
-------

Only show the list of hidden system tray items when a hidden item is expanded

As discussed on the forums
https://forum.kde.org/viewtopic.php?f=285&t=122794&sid=5d2a526b8f6146b1f52f0c75b7600871

FEATURE: 334823

Diffs
-----

  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml e938ec6 

Diff: https://git.reviewboard.kde.org/r/120778/diff/

Testing
-------

Matches the mockups

Opened non hidden item
Opened hidden item from arrow, and selected some
Tested opening the battery plasmoid then plugging/unplugging to make it hide/not. \
Everything all looks OK.

Thanks,

David Edmundson

--===============5526378571436659808==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120778/">https://git.reviewboard.kde.org/r/120778/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Oct. 27, 2014, 12:16 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Only show the list of hidden system tray items when a \
hidden item is expanded</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">As discussed on the forums \
https://forum.kde.org/viewtopic.php?f=285&amp;t=122794&amp;sid=5d2a526b8f6146b1f52f0c75b7600871</p>
 <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">FEATURE: 334823</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Matches the mockups</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Opened non hidden item Opened hidden item from arrow, and selected some
Tested opening the battery plasmoid then plugging/unplugging to make it hide/not. \
Everything all looks OK.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemtray/package/contents/ui/ExpandedRepresentation.qml <span \
style="color: grey">(e938ec6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120778/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5526378571436659808==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 