[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Powerdevil] [Bug 340206] New: do not use Version from org.freedesktop.systemd1.Manager in checkSyst
From:       Török Edwin <edwin+kde () etorok ! net>
Date:       2014-10-21 17:28:32
Message-ID: bug-340206-165951 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=340206

            Bug ID: 340206
           Summary: do not use Version from
                    org.freedesktop.systemd1.Manager in
                    checkSystemdVersion
           Product: Powerdevil
           Version: unspecified
          Platform: Debian unstable
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: plasma-devel@kde.org
          Reporter: edwin+kde@etorok.net

According to the documentation [0] Version is not part of the API and "it
should not be parsed, one may not assume the version to be formatted in any
particular way.".

However checkSystemdVersion() in
./powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp uses Version.

The problem is that systemd-shim doesn't implement version, and this results in
the loss of the Sleep/Hibernate buttons from the KDE menu (see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747180).

Although it is rather simple to implement 'Version' in systemd-shim, I don't
know if that should be done given that the documentation says it should not be
used in the first place.

[0] http://www.freedesktop.org/wiki/Software/systemd/dbus/

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic