'Re: Review Request 120569: Save the default email client into the group [Default Applications]'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120569: Save the default email client into the group [Default Applications]
From:       "David Faure" <faure () kde ! org>
Date:       2014-10-18 9:58:14
Message-ID: 20141018095814.21223.53828 () probe ! kde ! org
[Download RAW message or body]

--===============7565367081406269802==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120569/#review68651
-----------------------------------------------------------

Ship it!

Sounds good. We could go one step further for interoperability and replace all uses \
of the "EmailClient" key (e.g. in KToolInvocation::invokeMailer) with a query for the \
scheme handler for mailto. So setting the mail client in other environments would \
work in KDE, and so that we don't have to deal with two possibily conflicting \
settings (the EmailClient and the x-scheme-handler/mailto.

- David Faure

On Oct. 12, 2014, 8:43 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120569/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2014, 8:43 p.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Save the default email client by writing x-scheme-handler/mailto into the group \
> [Default Applications] in the file mimeapps.list . Nowadays, many applications look \
> at user preferences for x-scheme-handler/mailto to determine the default email \
> client, so setting this value would increase interoperability with these \
> applications. 
> regards,
> 
> Luc Menut - Mageia
> 
> PS: I don't have write access to kde git, so could you commit the change if the \
> patch looks fine. Thanks. 
> 
> Diffs
> -----
> 
> kcms/componentchooser/componentchooseremail.h e8d91a8 
> kcms/componentchooser/componentchooseremail.cpp b9c53ee 
> 
> Diff: https://git.reviewboard.kde.org/r/120569/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luc Menut
> 
> 

--===============7565367081406269802==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120569/">https://git.reviewboard.kde.org/r/120569/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sounds good. We could go one step further for interoperability and replace \
all uses of the "EmailClient" key (e.g. in KToolInvocation::invokeMailer) with a \
query for the scheme handler for mailto. So setting the mail client in other \
environments would work in KDE, and so that we don't have to deal with two possibily \
conflicting settings (the EmailClient and the x-scheme-handler/mailto.</p></pre>  <br \
/>

<p>- David Faure</p>

<br />
<p>On October 12th, 2014, 8:43 p.m. UTC, Luc Menut wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Faure.</div>
<div>By Luc Menut.</div>

<p style="color: grey;"><i>Updated Oct. 12, 2014, 8:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Save the default email client by writing \
x-scheme-handler/mailto into the group [Default Applications] in the file \
mimeapps.list . Nowadays, many applications look at user preferences for \
x-scheme-handler/mailto to determine the default email client, so setting this value \
would increase interoperability with these applications.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">regards,</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Luc Menut - Mageia</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">PS: I don't have write access to kde git, so could you commit the change if \
the patch looks fine. Thanks.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/componentchooser/componentchooseremail.h <span style="color: \
grey">(e8d91a8)</span></li>

 <li>kcms/componentchooser/componentchooseremail.cpp <span style="color: \
grey">(b9c53ee)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120569/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7565367081406269802==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 