'Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-10-06 15:21:42
Message-ID: 20141006152142.10359.55475 () probe ! kde ! org
[Download RAW message or body]

--===============1282661048092689487==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120441/#review68006
-----------------------------------------------------------

processui/ProcessModel.cpp
<https://git.reviewboard.kde.org/r/120441/#comment47399>

    you seem to be losing the precision here.

processui/ProcessModel.cpp
<https://git.reviewboard.kde.org/r/120441/#comment47400>

    why change in the comment?

- Martin Gräßlin

On Sept. 30, 2014, 7:40 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120441/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 7:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> some libs needed just headers removal, other something more ...
> found out that just by calling find_package(KF5KDELibs4Support) adds compat macros, \
> even w/o linking to it. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 61bd704 
> ksgrd/CMakeLists.txt 64ad24a 
> ksgrd/SensorManager.cpp 9e1534a 
> lsofui/CMakeLists.txt 2b0c8ac 
> lsofui/lsof.h e87ac26 
> processcore/CMakeLists.txt 0ca833e 
> processcore/processes.cpp 3e63218 
> processcore/processes_atop_p.cpp 369df36 
> processcore/processes_remote_p.cpp 361bf24 
> processui/CMakeLists.txt 150e198 
> processui/KTextEditVT.cpp 064737b 
> processui/ProcessFilter.cpp b37766e 
> processui/ProcessModel.cpp 8b87d41 
> processui/ProcessModel_p.h 6bc9d09 
> processui/ReniceDlg.h fa445a5 
> processui/ReniceDlg.cpp 218412c 
> processui/ksysguardprocesslist.cpp d3403cc 
> processui/scripting.cpp fd0a610 
> signalplotter/CMakeLists.txt 67aa8bb 
> signalplotter/kgraphicssignalplotter.h 9f698d4 
> signalplotter/ksignalplotter.cpp 91d9eee 
> tests/CMakeLists.txt a74c6a2 
> tests/graphicssignalplotterbenchmark.cpp e27eb1a 
> tests/processtest.cpp 6aa9809 
> tests/signalplotterbenchmark.cpp 8b827d6 
> tests/signalplottertest.cpp bb2108e 
> 
> Diff: https://git.reviewboard.kde.org/r/120441/diff/
> 
> 
> Testing
> -------
> 
> builds, tests pass, ksysguard functions as it did
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
> 

--===============1282661048092689487==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120441/">https://git.reviewboard.kde.org/r/120441/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line91" \
style="color: black; font-weight: bold; text-decoration: \
underline;">processui/ProcessModel.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
QString formatByteSize(qlonglong amountInKB, int units) {</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">87</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">return</span> <span class="n">kString</span><span class="p">.</span><span \
class="n">arg</span><span class="p">(</span><span class="n"><span \
class="hl">KGlobal</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span class="hl">l</span>ocale</span><span \
class="p">()</span><span class="o"><span class="hl">-&gt;</span></span><span \
class="n"><span class="hl">formatNumber</span></span><span class="p">(</span><span \
class="n">amountInKB</span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="mi"><span class="hl">0</span></span><span \
class="p">));</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">88</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="k">return</span> <span \
class="n">kString</span><span class="p">.</span><span class="n">arg</span><span \
class="p">(</span><span class="n"><span class="hl">QL</span>ocale</span><span \
class="p">()<span class="hl">.</span></span><span class="n"><span \
class="hl">toString</span></span><span class="p">(</span><span \
class="n">amountInKB</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">88</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsMB</span>:</pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">89</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsMB</span>:</pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">89</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">amount</span> <span class="o">=</span> <span \
class="n">amountInKB</span><span class="o">/</span><span \
class="mf">1024.0</span><span class="p">;</span></pre></td>  <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">90</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">amount</span> <span class="o">=</span> <span \
class="n">amountInKB</span><span class="o">/</span><span \
class="mf">1024.0</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">90</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">return</span> <span class="n">mString</span><span class="p">.</span><span \
class="n">arg</span><span class="p">(</span><span class="n"><span \
class="hl">KGlobal</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span class="hl">l</span>ocale</span><span \
class="p">()</span><span class="o"><span class="hl">-&gt;</span></span><span \
class="n"><span class="hl">formatNumber</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="mi"><span class="hl">1</span></span><span \
class="p">));</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">91</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="k">return</span> <span \
class="n">mString</span><span class="p">.</span><span class="n">arg</span><span \
class="p">(</span><span class="n"><span class="hl">QL</span>ocale</span><span \
class="p">()<span class="hl">.</span></span><span class="n"><span \
class="hl">toString</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">91</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsGB</span>:</pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsGB</span>:</pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">92</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">amount</span> <span class="o">=</span> <span \
class="n">amountInKB</span><span class="o">/</span><span class="p">(</span><span \
class="mf">1024.0</span><span class="o">*</span><span class="mf">1024.0</span><span \
class="p">);</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">93</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="n">amount</span> <span \
class="o">=</span> <span class="n">amountInKB</span><span class="o">/</span><span \
class="p">(</span><span class="mf">1024.0</span><span class="o">*</span><span \
class="mf">1024.0</span><span class="p">);</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">93</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span><span class="p">(</span><span class="n">amount</span> <span \
class="o">&lt;</span> <span class="mf">0.1</span> <span class="o">&amp;&amp;</span> \
<span class="n">amount</span> <span class="o">&gt;</span> <span \
class="mf">0.05</span><span class="p">)</span> <span class="n">amount</span> <span \
class="o">=</span> <span class="mf">0.1</span><span class="p">;</span></pre></td>  \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">94</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span><span class="p">(</span><span class="n">amount</span> <span \
class="o">&lt;</span> <span class="mf">0.1</span> <span class="o">&amp;&amp;</span> \
<span class="n">amount</span> <span class="o">&gt;</span> <span \
class="mf">0.05</span><span class="p">)</span> <span class="n">amount</span> <span \
class="o">=</span> <span class="mf">0.1</span><span class="p">;</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">94</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">return</span> <span class="n">gString</span><span class="p">.</span><span \
class="n">arg</span><span class="p">(</span><span class="n"><span \
class="hl">KGlobal</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span class="hl">l</span>ocale</span><span \
class="p">()</span><span class="o"><span class="hl">-&gt;</span></span><span \
class="n"><span class="hl">formatNumber</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="mi"><span class="hl">1</span></span><span \
class="p">));</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">95</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="k">return</span> <span \
class="n">gString</span><span class="p">.</span><span class="n">arg</span><span \
class="p">(</span><span class="n"><span class="hl">QL</span>ocale</span><span \
class="p">()<span class="hl">.</span></span><span class="n"><span \
class="hl">toString</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">95</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsTB</span>:</pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">96</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsTB</span>:</pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">96</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">amount</span> <span class="o">=</span> <span \
class="n">amountInKB</span><span class="o">/</span><span class="p">(</span><span \
class="mf">1024.0</span><span class="o">*</span><span class="mf">1024.0</span><span \
class="o">*</span><span class="mf">1024.0</span><span class="p">);</span></pre></td>  \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">97</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">amount</span> <span class="o">=</span> <span \
class="n">amountInKB</span><span class="o">/</span><span class="p">(</span><span \
class="mf">1024.0</span><span class="o">*</span><span class="mf">1024.0</span><span \
class="o">*</span><span class="mf">1024.0</span><span class="p">);</span></pre></td>  \
</tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">97</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span><span class="p">(</span><span class="n">amount</span> <span \
class="o">&lt;</span> <span class="mf">0.1</span> <span class="o">&amp;&amp;</span> \
<span class="n">amount</span> <span class="o">&gt;</span> <span \
class="mf">0.05</span><span class="p">)</span> <span class="n">amount</span> <span \
class="o">=</span> <span class="mf">0.1</span><span class="p">;</span></pre></td>  \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">98</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span><span class="p">(</span><span class="n">amount</span> <span \
class="o">&lt;</span> <span class="mf">0.1</span> <span class="o">&amp;&amp;</span> \
<span class="n">amount</span> <span class="o">&gt;</span> <span \
class="mf">0.05</span><span class="p">)</span> <span class="n">amount</span> <span \
class="o">=</span> <span class="mf">0.1</span><span class="p">;</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">98</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">return</span> <span class="n">tString</span><span class="p">.</span><span \
class="n">arg</span><span class="p">(</span><span class="n"><span \
class="hl">KGlobal</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span class="hl">l</span>ocale</span><span \
class="p">()</span><span class="o"><span class="hl">-&gt;</span></span><span \
class="n"><span class="hl">formatNumber</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="mi"><span class="hl">1</span></span><span \
class="p">));</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">99</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="k">return</span> <span \
class="n">tString</span><span class="p">.</span><span class="n">arg</span><span \
class="p">(</span><span class="n"><span class="hl">QL</span>ocale</span><span \
class="p">()<span class="hl">.</span></span><span class="n"><span \
class="hl">toString</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">99</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsPB</span>:</pre></td>  <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">100</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span \
class="k">case</span> <span class="n">UnitsPB</span>:</pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">100</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">amount</span> <span class="o">=</span> <span \
class="n">amountInKB</span><span class="o">/</span><span class="p">(</span><span \
class="mf">1024.0</span><span class="o">*</span><span class="mf">1024.0</span><span \
class="o">*</span><span class="mf">1024.0</span><span class="o">*</span><span \
class="mf">1024.0</span><span class="p">);</span></pre></td>  <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">101</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">amount</span> <span class="o">=</span> <span \
class="n">amountInKB</span><span class="o">/</span><span class="p">(</span><span \
class="mf">1024.0</span><span class="o">*</span><span class="mf">1024.0</span><span \
class="o">*</span><span class="mf">1024.0</span><span class="o">*</span><span \
class="mf">1024.0</span><span class="p">);</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">101</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span><span class="p">(</span><span class="n">amount</span> <span \
class="o">&lt;</span> <span class="mf">0.1</span> <span class="o">&amp;&amp;</span> \
<span class="n">amount</span> <span class="o">&gt;</span> <span \
class="mf">0.05</span><span class="p">)</span> <span class="n">amount</span> <span \
class="o">=</span> <span class="mf">0.1</span><span class="p">;</span></pre></td>  \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">102</font></th>  <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span><span class="p">(</span><span class="n">amount</span> <span \
class="o">&lt;</span> <span class="mf">0.1</span> <span class="o">&amp;&amp;</span> \
<span class="n">amount</span> <span class="o">&gt;</span> <span \
class="mf">0.05</span><span class="p">)</span> <span class="n">amount</span> <span \
class="o">=</span> <span class="mf">0.1</span><span class="p">;</span></pre></td>  \
</tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">102</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">return</span> <span class="n">pString</span><span class="p">.</span><span \
class="n">arg</span><span class="p">(</span><span class="n"><span \
class="hl">KGlobal</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span class="hl">l</span>ocale</span><span \
class="p">()</span><span class="o"><span class="hl">-&gt;</span></span><span \
class="n"><span class="hl">formatNumber</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="mi"><span class="hl">1</span></span><span \
class="p">));</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">103</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">        <span class="k">return</span> <span \
class="n">pString</span><span class="p">.</span><span class="n">arg</span><span \
class="p">(</span><span class="n"><span class="hl">QL</span>ocale</span><span \
class="p">()<span class="hl">.</span></span><span class="n"><span \
class="hl">toString</span></span><span class="p">(</span><span \
class="n">amount</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
seem to be losing the precision here.</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/120441/diff/2/?file=315895#file315895line568" \
style="color: black; font-weight: bold; text-decoration: \
underline;">processui/ProcessModel.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ProcessModelPrivate::updateWindowInfo(WId wid, unsigned int properties, bool \
newWindow)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">563</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">//    <span \
class="hl">k</span>Debug() &lt;&lt; &quot;update all processes: &quot; &lt;&lt; \
QTime::currentTime().toString(&quot;hh:mm:ss.zzz&quot;);</span></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">564</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">//    <span class="hl">q</span>Debug() &lt;&lt; &quot;update all \
processes: &quot; &lt;&lt; \
QTime::currentTime().toString(&quot;hh:mm:ss.zzz&quot;);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
change in the comment?</p></pre>  </div>
</div>
<br />

<p>- Martin Gräßlin</p>

<br />
<p>On September 30th, 2014, 7:40 p.m. CEST, Hrvoje Senjan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated Sept. 30, 2014, 7:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">some libs needed just headers removal, other something \
more ... found out that just by calling find_package(KF5KDELibs4Support) adds compat \
macros, even w/o linking to it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds, tests pass, ksysguard functions as it \
did</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(61bd704)</span></li>

 <li>ksgrd/CMakeLists.txt <span style="color: grey">(64ad24a)</span></li>

 <li>ksgrd/SensorManager.cpp <span style="color: grey">(9e1534a)</span></li>

 <li>lsofui/CMakeLists.txt <span style="color: grey">(2b0c8ac)</span></li>

 <li>lsofui/lsof.h <span style="color: grey">(e87ac26)</span></li>

 <li>processcore/CMakeLists.txt <span style="color: grey">(0ca833e)</span></li>

 <li>processcore/processes.cpp <span style="color: grey">(3e63218)</span></li>

 <li>processcore/processes_atop_p.cpp <span style="color: grey">(369df36)</span></li>

 <li>processcore/processes_remote_p.cpp <span style="color: \
grey">(361bf24)</span></li>

 <li>processui/CMakeLists.txt <span style="color: grey">(150e198)</span></li>

 <li>processui/KTextEditVT.cpp <span style="color: grey">(064737b)</span></li>

 <li>processui/ProcessFilter.cpp <span style="color: grey">(b37766e)</span></li>

 <li>processui/ProcessModel.cpp <span style="color: grey">(8b87d41)</span></li>

 <li>processui/ProcessModel_p.h <span style="color: grey">(6bc9d09)</span></li>

 <li>processui/ReniceDlg.h <span style="color: grey">(fa445a5)</span></li>

 <li>processui/ReniceDlg.cpp <span style="color: grey">(218412c)</span></li>

 <li>processui/ksysguardprocesslist.cpp <span style="color: \
grey">(d3403cc)</span></li>

 <li>processui/scripting.cpp <span style="color: grey">(fd0a610)</span></li>

 <li>signalplotter/CMakeLists.txt <span style="color: grey">(67aa8bb)</span></li>

 <li>signalplotter/kgraphicssignalplotter.h <span style="color: \
grey">(9f698d4)</span></li>

 <li>signalplotter/ksignalplotter.cpp <span style="color: grey">(91d9eee)</span></li>

 <li>tests/CMakeLists.txt <span style="color: grey">(a74c6a2)</span></li>

 <li>tests/graphicssignalplotterbenchmark.cpp <span style="color: \
grey">(e27eb1a)</span></li>

 <li>tests/processtest.cpp <span style="color: grey">(6aa9809)</span></li>

 <li>tests/signalplotterbenchmark.cpp <span style="color: grey">(8b827d6)</span></li>

 <li>tests/signalplottertest.cpp <span style="color: grey">(bb2108e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120441/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1282661048092689487==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 