'Re: Review Request 120455: Avoid a lot of syncs to FavoritesModel in kickoff'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120455: Avoid a lot of syncs to FavoritesModel in kickoff
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-10-01 18:34:23
Message-ID: 20141001183423.15675.93061 () probe ! kde ! org
[Download RAW message or body]

--===============8244721516967034369==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120455/
-----------------------------------------------------------

(Updated Oct. 1, 2014, 6:34 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-desktop

Description
-------

Avoid a lot of syncs to FavoritesModel in kickoff

Current code loaded the list of favourites into a string. It then
readded them one by one syncing the config after each change.

At the end the config is the same as when we started but with n config writes in
the meantime.

Splitting add and load methods solves this.

This should hopefully fix lockups as we're no longer writing to kickoffrc so often on \
load as well as give us a significant speed boost on the initial open.

BUG: 339451

Diffs
-----

  applets/kickoff/core/favoritesmodel.h 27a0626 
  applets/kickoff/core/favoritesmodel.cpp f05588b 

Diff: https://git.reviewboard.kde.org/r/120455/diff/

Testing
-------

Put a breakpoint on Kickoff::FavoritesModel::Private::save

checked this wasn't called anymore and favourites still loaded correctly.

Thanks,

David Edmundson

--===============8244721516967034369==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120455/">https://git.reviewboard.kde.org/r/120455/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Oct. 1, 2014, 6:34 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Avoid a lot of syncs to FavoritesModel in kickoff</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Current code loaded the list of favourites into a \
string. It then<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> readded them one by one syncing the config after \
each change.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">At the end the config is the same as when we started \
but with n config writes in<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> the meantime.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Splitting add and load methods solves this.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This should hopefully fix lockups as we're no longer writing to kickoffrc \
so often on load as well as give us a significant speed boost on the initial \
open.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 339451</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Put a breakpoint on \
Kickoff::FavoritesModel::Private::save</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">checked this wasn't \
called anymore and favourites still loaded correctly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kickoff/core/favoritesmodel.h <span style="color: \
grey">(27a0626)</span></li>

 <li>applets/kickoff/core/favoritesmodel.cpp <span style="color: \
grey">(f05588b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120455/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8244721516967034369==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 