--===============0632834479037116313== Content-Type: multipart/alternative; boundary="===============1420656418085839225==" --===============1420656418085839225== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120424/ ----------------------------------------------------------- (Updated Sept. 29, 2014, 4:57 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: breeze Description ------- (commit 1) Create kde4 config if it does not exist If there is no KDE4 directory and KDEHOME is not set. Kdelibs4Migration returns an empty path. For most usecases this is fine as it means there is nothing to import however in our unusual case we are writing data so we should manually create it. BUG: 338422 -- (commit 2) Remove check for hasWidgetStyle This was needed when using QtCurve. Now we are using Breeze we know fully well we have it installed as it's in the same repo. Diffs ----- misc/kde4breeze/src/main.cpp b8fedac Diff: https://git.reviewboard.kde.org/r/120424/diff/ Testing ------- unset KDEHOME mv .kde4 myOldHome ; /opt/kde5/lib64/kconf_update_bin/kde4breeze checked .kde4/share/config/kdeglobals had some stuff in it. Thanks, David Edmundson --===============1420656418085839225== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120424/

This change has been marked as submitted.

Review request for Plasma.
By David Edmundson.

Updated Sept. 29, 2014, 4:57 p.m.

Repository: breeze

Description 

(commit 1)


Create kde4 config if it does not exist


If there is no KDE4 directory and KDEHOME is not set. Kdelibs4Migration

returns an empty path.


For most usecases this is fine as it means there is nothing to import

however in our unusual case we are writing data so we should manually

create it.


BUG: 338422


--


(commit 2)

Remove check for hasWidgetStyle


This was needed when using QtCurve.

Now we are using Breeze we know fully well we have it installed as it's

in the same repo.

Testing 

unset KDEHOME

mv .kde4 myOldHome ; /opt/kde5/lib64/kconf_update_bin/kde4breeze


checked .kde4/share/config/kdeglobals had some stuff in it.

Diffs

  • misc/kde4breeze/src/main.cpp (b8fedac)

View Diff
--===============1420656418085839225==-- --===============0632834479037116313== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0632834479037116313==--