[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120424: Fix kde4breeze affecting Qt4 apps on clean installations
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-09-29 15:51:37
Message-ID: 20140929155137.15676.26044 () probe ! kde ! org
[Download RAW message or body]
--===============6972849826900676279==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120424/#review67634
-----------------------------------------------------------
Ship it!
Inviala!
- Marco Martin
On Set. 29, 2014, 3:40 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120424/
> -----------------------------------------------------------
>
> (Updated Set. 29, 2014, 3:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: breeze
>
>
> Description
> -------
>
> (commit 1)
>
> Create kde4 config if it does not exist
>
> If there is no KDE4 directory and KDEHOME is not set. Kdelibs4Migration
> returns an empty path.
>
> For most usecases this is fine as it means there is nothing to import
> however in our unusual case we are writing data so we should manually
> create it.
>
> BUG: 338422
>
> --
>
> (commit 2)
> Remove check for hasWidgetStyle
>
> This was needed when using QtCurve.
> Now we are using Breeze we know fully well we have it installed as it's
> in the same repo.
>
>
> Diffs
> -----
>
> misc/kde4breeze/src/main.cpp b8fedac
>
> Diff: https://git.reviewboard.kde.org/r/120424/diff/
>
>
> Testing
> -------
>
> unset KDEHOME
> mv .kde4 myOldHome ; /opt/kde5/lib64/kconf_update_bin/kde4breeze
>
>
> checked .kde4/share/config/kdeglobals had some stuff in it.
>
>
> Thanks,
>
> David Edmundson
>
>
--===============6972849826900676279==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120424/">https://git.reviewboard.kde.org/r/120424/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Inviala!</p></pre> <br />
<p>- Marco Martin</p>
<br />
<p>On settembre 29th, 2014, 3:40 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Set. 29, 2014, 3:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(commit 1)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Create kde4 config if \
it does not exist</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If there is no KDE4 directory and \
KDEHOME is not set. Kdelibs4Migration<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> returns an empty \
path.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For most usecases this is fine as it means there is \
nothing to import<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> however in our unusual case we are writing data so \
we should manually<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> create it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 338422</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">--</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(commit 2)<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Remove check for hasWidgetStyle</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This was needed when using QtCurve.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> Now \
we are using Breeze we know fully well we have it installed as it's<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> in the same repo.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">unset KDEHOME<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> mv .kde4 myOldHome ; \
/opt/kde5/lib64/kconf_update_bin/kde4breeze</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">checked \
.kde4/share/config/kdeglobals had some stuff in it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>misc/kde4breeze/src/main.cpp <span style="color: grey">(b8fedac)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120424/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6972849826900676279==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic