'Re: Review Request 120419: [ksmserver] Get rid of KDELibs4Support...'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120419: [ksmserver] Get rid of KDELibs4Support...
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2014-09-29 15:46:13
Message-ID: 20140929154613.15675.54169 () probe ! kde ! org
[Download RAW message or body]

--===============6783655249567381915==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120419/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 3:46 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-workspace

Description
-------

...as much as possible. still left some Solid usage.

Diffs
-----

  ksmserver/CMakeLists.txt 49870fb 
  ksmserver/client.cpp 6232d71 
  ksmserver/legacy.cpp bb102a8 
  ksmserver/main.cpp 75ca468 
  ksmserver/server.cpp a2cd6e6 
  ksmserver/shutdown.cpp b67a6a9 
  ksmserver/shutdowndlg.cpp 5c484f3 
  ksmserver/startup.cpp a173237 

Diff: https://git.reviewboard.kde.org/r/120419/diff/

Testing
-------

starting/shutdown, restoring session/clean session all seem to work

Thanks,

Hrvoje Senjan

--===============6783655249567381915==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120419/">https://git.reviewboard.kde.org/r/120419/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2014, 3:46 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">...as much as possible. still left some Solid \
usage.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">starting/shutdown, restoring session/clean session all \
seem to work</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/CMakeLists.txt <span style="color: grey">(49870fb)</span></li>

 <li>ksmserver/client.cpp <span style="color: grey">(6232d71)</span></li>

 <li>ksmserver/legacy.cpp <span style="color: grey">(bb102a8)</span></li>

 <li>ksmserver/main.cpp <span style="color: grey">(75ca468)</span></li>

 <li>ksmserver/server.cpp <span style="color: grey">(a2cd6e6)</span></li>

 <li>ksmserver/shutdown.cpp <span style="color: grey">(b67a6a9)</span></li>

 <li>ksmserver/shutdowndlg.cpp <span style="color: grey">(5c484f3)</span></li>

 <li>ksmserver/startup.cpp <span style="color: grey">(a173237)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120419/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6783655249567381915==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 