This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119764/

On September 19th, 2014, 2 p.m. UTC, Eike Hein wrote:
Makes sense to me and seems to work well in testing.
On September 28th, 2014, 12:46 p.m. UTC, Eike Hein wrote:
Fuminobu, do you need someone to commit this for you?
On September 28th, 2014, 12:48 p.m. UTC, Fuminobu TAKEYAMA wrote:
Yes, I don't have any commit rights for KDE repositories. (This is the first change)

Pushed it. Thanks!

- Eike

On September 29th, 2014, 9:22 a.m. UTC, Fuminobu TAKEYAMA wrote:

Review request for Plasma.

By Fuminobu TAKEYAMA.

Updated Sept. 29, 2014, 9:22 a.m.

Bugs: 105797

Repository: plasma-desktop

Description

Fix kcontrol/fonts saves fontconfig settings when it is opened. Add "System default" to each config. It removes a corresponding fontconfig entry made by this module. "System default" is now default values for sub-pixel rendering and hinting.

Selecting "System default" also reverts Xft configs.

BUG: 105797

Testing

Remove ~/.fonts.conf and ~/.config/fontconfig/*
Open the font setting module and ensure that

~/.config/fontconfig/fonts.conf is not created before "Apply"
If "System Settings" are selected for "Use anti-aliasing" then

~/.config/fontconfig/fonts.conf (the name depends on environment)

does not contains the following entries:

- rgba

- hinting

- hintstyle

- antialias
Enable antialiasing and set hinting style "None". The fontconfig file should contains:

 <match target="font">

  <edit mode="assign" name="hinting">

   <bool>false</bool>

  </edit>

 </match>

 <match target="font">

  <edit mode="assign" name="hintstyle">

   <const>hintnone</const>

  </edit>

 </match>

 <match target="font">

  <edit mode="assign" name="antialias">

   <bool>true</bool>

  </edit>

 </match>
$ xrdb -q | grep hint

should return empty
Then revert hinting style to "System default". The file should not contains:

- hinting

- hintstyle
Changing sub-pixel rendering to "None" adds:

 <match target="font">

  <edit mode="assign" name="rgba">

   <const>none</const>

  </edit>

 </match>

to the file.
$ xrdb -q | grep hint

now returns:

Xft.hinting:    0

Xft.hintstyle:  hintnone

Diffs

kcms/fonts/kxftconfig.h (9efa9f5857ee81881916936b5036f79d3bb329c2)
kcms/fonts/kxftconfig.cpp (6f3465f1cbc7b5231c11a6be40ee3c4ea96bb94e)
kcms/fonts/fonts.cpp (1b5175eceb44ab93b642e02daca3e8a3a758a389)
kcms/fonts/fonts.h (5b9f5d895cdfbf385f06994c182a83ae3722c2e1)

View Diff