[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120407: Show application title if SNI does not provide a tooltip
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-09-28 16:16:46
Message-ID: 20140928161646.15676.38313 () probe ! kde ! org
[Download RAW message or body]
--===============5800037675829464235==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 28, 2014, 4:13 nachm., David Edmundson wrote:
> > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp, line \
> > 439 <https://git.reviewboard.kde.org/r/120407/diff/1/?file=315614#file315614line439>
> >
> > this looks wrong.
> > otherwise if you have a title and a subtitle we'll always set it to the subtitle
> >
> > else if?
I don't see anything wrong with it.
The ifs are just for only emitting the signal when it actually changed.
title ? tooltip title
subtitle ? tooltip text
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120407/#review67566
-----------------------------------------------------------
On Sept. 28, 2014, 4:06 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120407/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2014, 4:06 nachm.)
>
>
> Review request for Plasma.
>
>
> Bugs: 337710
> https://bugs.kde.org/show_bug.cgi?id=337710
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Since the SNI spec does not requires you to provide a tooltip, this patch makes the \
> tooltip show the application icon and name in case no tooltip is provided. This \
> also restores Plasma 4.x behavior afaict.
>
> Diffs
> -----
>
> applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp 14458e9
>
> Diff: https://git.reviewboard.kde.org/r/120407/diff/
>
>
> Testing
> -------
>
> - Plugged in and out SD card, devicenotifier updated its icon accordingly
> - Mousewheel'd kmix, tooltip text was updated properly
> - Steam tooltip now has icon and text
>
>
> File Attachments
> ----------------
>
> Steam tooltip
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============5800037675829464235==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120407/">https://git.reviewboard.kde.org/r/120407/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 28th, 2014, 4:13 nachm. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120407/diff/1/?file=315614#file315614line439" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DBusSystemTrayTask::syncIcons(const Plasma::DataEngine::Data \
&properties)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">438</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">subTitle</span> <span \
class="o">!=</span> <span class="n">m_tooltipText</span><span class="p">)</span> \
<span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
looks wrong.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> otherwise if you have a title and a subtitle we'll \
always set it to the subtitle</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">else if?</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I don't see anything wrong with it.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> The ifs are just for \
only emitting the signal when it actually changed.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">title \
? tooltip title<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> subtitle ? tooltip text</p></pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On September 28th, 2014, 4:06 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2014, 4:06 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=337710">337710</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since the SNI spec does not requires you to provide a \
tooltip, this patch makes the tooltip show the application icon and name in case no \
tooltip is provided. This also restores Plasma 4.x behavior afaict.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Plugged in and out SD \
card, devicenotifier updated its icon accordingly</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Mousewheel'd kmix, tooltip text was updated properly</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Steam tooltip now has icon and text</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp <span \
style="color: grey">(14458e9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120407/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png">Steam \
tooltip</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5800037675829464235==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic