From kde-panel-devel Sun Sep 28 13:33:56 2014 From: "David Edmundson" Date: Sun, 28 Sep 2014 13:33:56 +0000 To: kde-panel-devel Subject: Re: Review Request 120352: Remove keyboard click volume setting Message-Id: <20140928133356.15676.6263 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141191126129617 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7322695360654875740==" --===============7322695360654875740== Content-Type: multipart/alternative; boundary="===============7093578330140691481==" --===============7093578330140691481== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/ ----------------------------------------------------------- (Updated Sept. 28, 2014, 1:33 p.m.) Review request for Plasma and Frederik Gladhorn. Changes ------- Added Frederick to weigh in on accessibility comments. Repository: plasma-desktop Description ------- They keyboard daemon had a weird option for making your system make a short beep whenever you pressed a key. This doesn't work and doesn't seem particularly useful. Diffs ----- kcms/keyboard/kcmmisc.h 411bdd2 kcms/keyboard/kcmmisc.cpp c63d06b kcms/keyboard/kcmmiscwidget.ui 37fbaf4 kcms/keyboard/keyboard_hardware.cpp df5f417 Diff: https://git.reviewboard.kde.org/r/120352/diff/ Testing ------- Thanks, David Edmundson --===============7093578330140691481== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/

Review request for Plasma and Frederik Gladhorn.
By David Edmundson.

Updated Sept. 28, 2014, 1:33 p.m.

Changes

Added Frederick to weigh in on accessibility comments.
Repository: plasma-desktop

Description 

They keyboard daemon had a weird option for making your system make a

short beep whenever you pressed a key.


This doesn't work and doesn't seem particularly useful.

Diffs

  • kcms/keyboard/kcmmisc.h (411bdd2)
  • kcms/keyboard/kcmmisc.cpp (c63d06b)
  • kcms/keyboard/kcmmiscwidget.ui (37fbaf4)
  • kcms/keyboard/keyboard_hardware.cpp (df5f417)

View Diff
--===============7093578330140691481==-- --===============7322695360654875740== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7322695360654875740==--