[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2014-09-27 20:05:14
Message-ID: 20140927200514.6971.76275 () probe ! kde ! org
[Download RAW message or body]
--===============7012516404753135082==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/#review67538
-----------------------------------------------------------
applets/digital-clock/package/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/120358/#comment47079>
The result of both of these i18ncs is exactly the same; plus both comments are \
not true if it's used for the tooltip.
However, changing the comments would violate string freeze. I'd suggest to \
possibly remove the i18nc altogether here as there are no localizable things (besides \
the order, but I guess we could live with that for a while).
- Martin Klapetek
On Sept. 27, 2014, 9:51 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120358/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2014, 9:51 p.m.)
>
>
> Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> DigitalClock: Add timezone information to digital clock tooltip.
>
> note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that \
> before committing.
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/DigitalClock.qml \
> 2beae00d090dfe03e94c4223ba36546ffeda45f2
> Diff: https://git.reviewboard.kde.org/r/120358/diff/
>
>
> Testing
> -------
>
> I ran it here with two timezones selected (Local and London). The date is local \
> date, but it was that way before anyway. The date next to each timezone is the date \
> for that timezone if dates are shown.
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============7012516404753135082==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120358/">https://git.reviewboard.kde.org/r/120358/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120358/diff/3/?file=315594#file315594line257" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/digital-clock/package/contents/ui/DigitalClock.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">226</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">returnString</span> <span class="o">+=</span> <span \
class="p">(</span><span class="nx">showDate</span> <span class="o">?</span> <span \
class="nx">i18nc</span><span class="p">(</span><span class="s2">"This composes \
time and a timezone into one string that's displayed in the clock applet (the \
main clock in the panel). "</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">227</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="o">+</span> <span class="s2">"%1 is the current time and %2 is \
either the timezone city or timezone code, depending on user \
settings"</span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">228</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s2">"%1 %2"</span><span class="p">,</span> <span \
class="nx">timezoneString</span><span class="p">,</span> <span \
class="nx">Qt</span><span class="p">.</span><span class="nx">formatTime</span><span \
class="p">(</span><span class="nx">dateTime</span><span class="p">,</span> <span \
class="nx">main</span><span class="p">.</span><span class="nx">timeFormat</span><span \
class="p">))</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">229</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="o">:</span> <span class="nx">i18nc</span><span class="p">(</span><span \
class="s2">"This composes time and a timezone into one string that's \
displayed in the clock applet (the main clock in the panel). "</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">230</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="o">+</span> <span class="s2">"From the previous case it's \
different that it doesn't add a new line and the timezone is \
first"</span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">231</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s2">"%1 %2"</span><span class="p">,</span> <span \
class="nx">timezoneString</span><span class="p">,</span> <span \
class="nx">Qt</span><span class="p">.</span><span class="nx">formatTime</span><span \
class="p">(</span><span class="nx">dateTime</span><span class="p">,</span> <span \
class="nx">main</span><span class="p">.</span><span class="nx">timeFormat</span><span \
class="p">)));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">232</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
result of both of these i18ncs is exactly the same; plus both comments are not true \
if it's used for the tooltip.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">However, changing the \
comments would violate string freeze. I'd suggest to possibly remove the i18nc \
altogether here as there are no localizable things (besides the order, but I guess we \
could live with that for a while).</p></pre> </div>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On September 27th, 2014, 9:51 p.m. CEST, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2014, 9:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">DigitalClock: Add timezone information to digital \
clock tooltip.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">note: My editor is dumb and removed the \
umlaut from Sebas' name, I'll fix that before committing.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I ran it here with two timezones selected (Local and \
London). The date is local date, but it was that way before anyway. The date next to \
each timezone is the date for that timezone if dates are shown.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(2beae00d090dfe03e94c4223ba36546ffeda45f2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120358/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7012516404753135082==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic