'Re: Review Request 120385: Cleanup system tray configuration'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120385: Cleanup system tray configuration
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-09-27 10:39:50
Message-ID: 20140927103950.6971.28066 () probe ! kde ! org
[Download RAW message or body]

--===============1065682660704831452==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120385/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 10:39 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Bugs: 339428
    https://bugs.kde.org/show_bug.cgi?id=339428

Repository: plasma-workspace

Description
-------

This patch cleans up the system tray configuration a bit, it does:
 - Remove dead properties and runtime warnings of items that no longer exist or that \
                I couldn't see being used
 - Use Array literal instead of new Array() or Array() which is faster
 - Use ColumnLayout instead of generic Column

And most importantly:
 - Emit configurationChanged signal when changing the ExtraItems because QML cannot \
detect changes that happen inside an Array. It can only detect when the whole \
property is assigned to something else - having a temp Array to push to and then \
assign would be a waste here, so I just emit the signal.

This patch does not, however, fix the apply button being broken when the dialog opens \
initially - my observations can be found in the related bug report.

Diffs
-----

  applets/systemtray/package/contents/ui/ConfigGeneral.qml 545ee32 

Diff: https://git.reviewboard.kde.org/r/120385/diff/

Testing
-------

Dialog looks the same, less warnings in the console and the apply button gets enabled \
when changing the extra items.

Thanks,

Kai Uwe Broulik

--===============1065682660704831452==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120385/">https://git.reviewboard.kde.org/r/120385/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Sept. 27, 2014, 10:39 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=339428">339428</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch cleans up the system tray configuration a \
bit, it does:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: normal;" />
 - Remove dead properties and runtime warnings of items that no longer exist or that \
I couldn't see being used<br style="padding: 0;text-rendering: inherit;margin: \
                0;line-height: inherit;white-space: normal;" />
 - Use Array literal instead of new Array() or Array() which is faster<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                normal;" />
 - Use ColumnLayout instead of generic Column</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">And most importantly:<br style="padding: \
                0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
                normal;" />
 - Emit configurationChanged signal when changing the ExtraItems because QML cannot \
detect changes that happen inside an Array. It can only detect when the whole \
property is assigned to something else - having a temp Array to push to and then \
assign would be a waste here, so I just emit the signal.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch does not, however, fix the apply button being broken when the dialog opens \
initially - my observations can be found in the related bug report.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Dialog looks the same, less warnings in the console \
and the apply button gets enabled when changing the extra items.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemtray/package/contents/ui/ConfigGeneral.qml <span style="color: \
grey">(545ee32)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120385/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1065682660704831452==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 