[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120374: Fix system tray icons not always properly centered in vertical panel
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-09-26 13:38:01
Message-ID: 20140926133801.6970.72652 () probe ! kde ! org
[Download RAW message or body]
--===============7766779901168995580==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 26, 2014, 11:56 a.m., Marco Martin wrote:
> > this is incorrect, it breaks the icons layout in the systray popup
>
> David Edmundson wrote:
> It doesn't /look/ broken here. Which part is messed up?
>
> David Edmundson wrote:
> [15:23] <mck182> d_ed: this part http://i.imgur.com/JL2PV1v.png
is fixed in master
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120374/#review67482
-----------------------------------------------------------
On Sept. 26, 2014, 8:23 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120374/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 8:23 a.m.)
>
>
> Review request for Plasma and Eike Hein.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Under certain circumstances in a vertical panel the icons in the tray might not be \
> centered horizontally. This patch fixes that both for status notifier items and \
> applets while keeping fitt's law in place.
>
> Diffs
> -----
>
> applets/systemtray/package/contents/ui/StatusNotifierItem.qml aad91f1
> applets/systemtray/package/contents/ui/TaskDelegate.qml 5230599
>
> Diff: https://git.reviewboard.kde.org/r/120374/diff/
>
>
> Testing
> -------
>
> Resized vertical panel, moved it around, expanded/collapsed, all seems to be \
> working still.
>
> File Attachments
> ----------------
>
> Before
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/6d7c5583-dd0a-4f8a-a9e0-de331f55c182__trayiconsbefore.png
> After
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/39f7ad29-3518-4d97-8d27-11c9e4dc1555__trayiconsafter.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============7766779901168995580==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120374/">https://git.reviewboard.kde.org/r/120374/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 26th, 2014, 11:56 a.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this is incorrect, it breaks the icons layout in the \
systray popup</p></pre> </blockquote>
<p>On September 26th, 2014, 1:20 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
doesn't /look/ broken here. Which part is messed up?</p></pre> </blockquote>
<p>On September 26th, 2014, 1:27 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">[15:23] <mck182> d_ed: this part \
http://i.imgur.com/JL2PV1v.png</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is \
fixed in master</p></pre> <br />
<p>- Marco</p>
<br />
<p>On September 26th, 2014, 8:23 a.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2014, 8:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Under certain circumstances in a vertical panel the \
icons in the tray might not be centered horizontally. This patch fixes that both for \
status notifier items and applets while keeping fitt's law in place.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Resized vertical panel, moved it around, \
expanded/collapsed, all seems to be working still.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/ui/StatusNotifierItem.qml <span \
style="color: grey">(aad91f1)</span></li>
<li>applets/systemtray/package/contents/ui/TaskDelegate.qml <span style="color: \
grey">(5230599)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120374/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/6d7c5583-dd0a-4f8a-a9e0-de331f55c182__trayiconsbefore.png">Before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/39f7ad29-3518-4d97-8d27-11c9e4dc1555__trayiconsafter.png">After</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7766779901168995580==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic