[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2014-09-25 17:49:51
Message-ID: 20140925174951.6971.86989 () probe ! kde ! org
[Download RAW message or body]
--===============2098294834476972220==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 25, 2014, 9:33 vorm., Kai Uwe Broulik wrote:
> > Can you provide a screenshot of the tooltip?
>
> Jeremy Whiting wrote:
> I'm using the same function to create the time format. but with a different \
> argument. I guess I could make two separate functions instead, but why not just use \
> the same one, when 90% of the code is the same? Anyway, I've added a couple \
> screenshots http://imgur.com/biI6prN,lbxJS4k and http://imgur.com/biI6prN,lbxJS4k#1 \
> though when I look at it admittedly the withDate one looks funny, and should have \
> the timezone first like the other one and outside of () also. I'll fix that and \
> post an update to this review.
Fair enough. Looks better than I expected. Yes, the date and the order looks awkward, \
and please add an empty line between the current date and the list of time zones. \
Thanks!
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/#review67406
-----------------------------------------------------------
On Sept. 25, 2014, 5:49 nachm., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120358/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 5:49 nachm.)
>
>
> Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> DigitalClock: Add timezone information to digital clock tooltip.
>
> note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that \
> before committing.
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/DigitalClock.qml \
> 00c9def8dffe1cdc24d377acab029b47bd57e602
> Diff: https://git.reviewboard.kde.org/r/120358/diff/
>
>
> Testing
> -------
>
> I ran it here with two timezones selected (Local and London). The date is local \
> date, but it was that way before anyway. The date next to each timezone is the date \
> for that timezone if dates are shown.
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============2098294834476972220==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120358/">https://git.reviewboard.kde.org/r/120358/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 25th, 2014, 9:33 vorm. UTC, <b>Kai \
Uwe Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can you provide a screenshot of the tooltip?</p></pre> \
</blockquote>
<p>On September 25th, 2014, 5:41 nachm. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
using the same function to create the time format. but with a different argument. I \
guess I could make two separate functions instead, but why not just use the same one, \
when 90% of the code is the same?<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Anyway, I've added a \
couple screenshots http://imgur.com/biI6prN,lbxJS4k and \
http://imgur.com/biI6prN,lbxJS4k#1 though when I look at it admittedly the withDate \
one looks funny, and should have the timezone first like the other one and outside of \
() also. I'll fix that and post an update to this review.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fair \
enough. Looks better than I expected. Yes, the date and the order looks awkward, and \
please add an empty line between the current date and the list of time zones. \
Thanks!</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On September 25th, 2014, 5:49 nachm. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Kai Uwe Broulik and Martin Klapetek.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2014, 5:49 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">DigitalClock: Add timezone information to digital \
clock tooltip.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">note: My editor is dumb and removed the \
umlaut from Sebas' name, I'll fix that before committing.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I ran it here with two timezones selected (Local and \
London). The date is local date, but it was that way before anyway. The date next to \
each timezone is the date for that timezone if dates are shown.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(00c9def8dffe1cdc24d377acab029b47bd57e602)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120358/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2098294834476972220==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic