'Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2014-09-25 2:11:37
Message-ID: 20140925021137.6970.93413 () probe ! kde ! org
[Download RAW message or body]

--===============6226150010356339132==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120358/
-----------------------------------------------------------

Review request for Plasma.

Repository: plasma-workspace

Description
-------

DigitalClock: Add timezone information to digital clock tooltip.

note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix that before \
committing.

Diffs
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml \
00c9def8dffe1cdc24d377acab029b47bd57e602 

Diff: https://git.reviewboard.kde.org/r/120358/diff/

Testing
-------

I ran it here with two timezones selected (Local and London). The date is local date, \
but it was that way before anyway. The date next to each timezone is the date for \
that timezone if dates are shown.

Thanks,

Jeremy Whiting

--===============6226150010356339132==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120358/">https://git.reviewboard.kde.org/r/120358/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Jeremy Whiting.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">DigitalClock: Add timezone information to digital \
clock tooltip.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">note: My editor is dumb and removed the \
umlaut from Sebas' name, I'll fix that before committing.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I ran it here with two timezones selected (Local and \
London). The date is local date, but it was that way before anyway. The date next to \
each timezone is the date for that timezone if dates are shown.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(00c9def8dffe1cdc24d377acab029b47bd57e602)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120358/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6226150010356339132==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 